Skip to content

Commit 74edc71

Browse files
akpm00sfrothwell
authored andcommitted
mm-oom-rework-oom-detection-checkpatch-fixes
Cc: David Rientjes <[email protected]> WARNING: line over 80 characters torvalds#99: FILE: mm/page_alloc.c:2965: + * zone list (with a backoff mechanism which is a function of no_progress_loops). WARNING: line over 80 characters torvalds#129: FILE: mm/page_alloc.c:2995: + * Keep reclaiming pages while there is a chance this will lead somewhere. WARNING: line over 80 characters torvalds#134: FILE: mm/page_alloc.c:3000: + for_each_zone_zonelist_nodemask(zone, z, ac->zonelist, ac->high_zoneidx, ac->nodemask) { WARNING: line over 80 characters torvalds#138: FILE: mm/page_alloc.c:3004: + available -= DIV_ROUND_UP(no_progress_loops * available, MAX_RECLAIM_RETRIES); WARNING: line over 80 characters torvalds#142: FILE: mm/page_alloc.c:3008: + * Would the allocation succeed if we reclaimed the whole available? WARNING: line over 80 characters torvalds#146: FILE: mm/page_alloc.c:3012: + /* Wait for some write requests to complete then retry */ total: 0 errors, 6 warnings, 202 lines checked ./patches/mm-oom-rework-oom-detection.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: David Rientjes <[email protected]> Cc: Hillf Danton <[email protected]> Cc: Johannes Weiner <[email protected]> Cc: KAMEZAWA Hiroyuki <[email protected]> Cc: Mel Gorman <[email protected]> Cc: Michal Hocko <[email protected]> Cc: Tetsuo Handa <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent b12385d commit 74edc71

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

mm/page_alloc.c

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2989,7 +2989,8 @@ static inline bool is_thp_gfp_mask(gfp_t gfp_mask)
29892989
* the last reclaim round), pages_reclaimed (cumulative number of reclaimed
29902990
* pages) and no_progress_loops (number of reclaim rounds without any progress
29912991
* in a row) is considered as well as the reclaimable pages on the applicable
2992-
* zone list (with a backoff mechanism which is a function of no_progress_loops).
2992+
* zone list (with a backoff mechanism which is a function of
2993+
* no_progress_loops).
29932994
*
29942995
* Returns true if a retry is viable or false to enter the oom path.
29952996
*/
@@ -3019,24 +3020,27 @@ should_reclaim_retry(gfp_t gfp_mask, unsigned order,
30193020
}
30203021

30213022
/*
3022-
* Keep reclaiming pages while there is a chance this will lead somewhere.
3023-
* If none of the target zones can satisfy our allocation request even
3024-
* if all reclaimable pages are considered then we are screwed and have
3025-
* to go OOM.
3023+
* Keep reclaiming pages while there is a chance this will lead
3024+
* somewhere. If none of the target zones can satisfy our allocation
3025+
* request even if all reclaimable pages are considered then we are
3026+
* screwed and have to go OOM.
30263027
*/
3027-
for_each_zone_zonelist_nodemask(zone, z, ac->zonelist, ac->high_zoneidx, ac->nodemask) {
3028+
for_each_zone_zonelist_nodemask(zone, z, ac->zonelist,
3029+
ac->high_zoneidx, ac->nodemask) {
30283030
unsigned long available;
30293031

30303032
available = zone_reclaimable_pages(zone);
3031-
available -= DIV_ROUND_UP(no_progress_loops * available, MAX_RECLAIM_RETRIES);
3033+
available -= DIV_ROUND_UP(no_progress_loops * available,
3034+
MAX_RECLAIM_RETRIES);
30323035
available += zone_page_state_snapshot(zone, NR_FREE_PAGES);
30333036

30343037
/*
3035-
* Would the allocation succeed if we reclaimed the whole available?
3038+
* Would the allocation succeed if we reclaimed the whole
3039+
* available?
30363040
*/
30373041
if (__zone_watermark_ok(zone, order, min_wmark_pages(zone),
30383042
ac->high_zoneidx, alloc_flags, available)) {
3039-
/* Wait for some write requests to complete then retry */
3043+
/* Wait for some writes to complete then retry */
30403044
wait_iff_congested(zone, BLK_RW_ASYNC, HZ/50);
30413045
return true;
30423046
}

0 commit comments

Comments
 (0)