Skip to content

List react-query v4 as a peer dependency #134

@IsaacLeeWebDev

Description

@IsaacLeeWebDev

Is your feature request related to a problem? Please describe.

Right now, this tool generates code that imports react-query like this:

import { UseQueryResult } from "@tanstack/react-query";

These imports don't work if you've installed a version of react-query before v4, whose imports have to look like this:

import { UseQueryResult } from "react-query";

Describe the solution you'd like
List react-query v4 and up as a peer dependency of this package

Describe alternatives you've considered
This tool could also support generating v3-style imports with a CLI option. That said, I could see how supporting old versions of react-query could go far beyond this one incompatibility, and I could see officially how providing that support could potentially significantly increase the maintenance demand of this package.

I suppose I could also run a string-replace to change @tanstack/react-query to react-query on every generated file.

Additional context

Activity

seriouslag

seriouslag commented on Jul 25, 2024

@seriouslag
Collaborator

Our api does not support that version of react query. That package should be changed to use the package under the @TanStack name.

IsaacLeeWebDev

IsaacLeeWebDev commented on Aug 2, 2024

@IsaacLeeWebDev
Author

Our api does not support that version of react query. That package should be changed to use the package under the TanStack name.

That's fine! That's why I suggested listing the tanstack-named package as a peer dependency, so that those using older versions get a warning message when they install the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @7nohe@seriouslag@IsaacLeeWebDev

        Issue actions

          List react-query v4 as a peer dependency · Issue #134 · 7nohe/openapi-react-query-codegen