Skip to content

Odin WiFi broken by DNS API change #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bulislaw opened this issue Oct 27, 2016 · 5 comments
Closed

Odin WiFi broken by DNS API change #3152

bulislaw opened this issue Oct 27, 2016 · 5 comments

Comments

@bulislaw
Copy link
Member

This change 1f4eb0aaa1499f8de88d10c5987af60c2395c9da by @geky broke compatibility of prebuilt WiFi library for Odin board.

Build failures:
  * UBLOX_EVK_ODIN_W2::GCC_ARM::TESTS-NETWORK-WIFI
        Building project wifi (UBLOX_EVK_ODIN_W2, GCC_ARM)
        Scan: GCC_ARM
        Scan: FEATURE_LWIP
        Scan: wifi
        Compile [100.0%]: main.cpp
        [Warning] cc.h@57,1: "BYTE_ORDER" redefined
        Link: wifi
        /Users/barsza01/devel/mbed/code/mbed-os/BUILD/tests/UBLOX_EVK_ODIN_W2/GCC_ARM/targets/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/sdk/TOOLCHAIN_GCC_ARM/libublox-odin-w2-driver.a(OdinWiFiInterface.o):(.rodata._ZTV17OdinWiFiInterface+0x30): undefined reference to `NetworkInterface::gethostbyname(char const*, SocketAddress*)'
        collect2: error: ld returned 1 exit status

@andreaslarssonublox could you rebase and rebuild the libraries please.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 28, 2016

Thanks @bulislaw for reporting this. Why the CI did not report this, did we miss something?

This change 1f4eb0a by @geky broke compatibility of prebuilt WiFi library for Odin board.

We need to be careful with this type of changes. Note taken.

@bulislaw
Copy link
Member Author

Yes :) We're missing WiFi tests and the EMAC is disabled by default. #3147

@geky
Copy link
Contributor

geky commented Oct 28, 2016

Changes like those are always a minefield, sorry for the trouble.

@bulislaw
Copy link
Member Author

Yeah, especially with a binaries in the sources, that's why I want to have tests for Odin. #3147

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 9, 2016

Fixed via #3221

@0xc0170 0xc0170 closed this as completed Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants