Skip to content

Remove FEATURE_COMMON_PAL from LoRaWAN stack #6893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattbrown015 opened this issue May 14, 2018 · 4 comments
Closed

Remove FEATURE_COMMON_PAL from LoRaWAN stack #6893

mattbrown015 opened this issue May 14, 2018 · 4 comments

Comments

@mattbrown015
Copy link
Contributor

Description

Remove use of FEATURE_COMMON_PAL from the LoRaWAN stack.

As I understand it, FEATURE_COMMON_PAL is unnecessary since Get rid of FEATURE_COMMON_PAL and FEATURE_NANOSTACK #6577. But, I removed '"target.features_add": ["COMMON_PAL"]' from my mbed_app.json and all the LoRaWAN trace disappeared.

Just a tidy up really.

Issue request type

[ ] Question
[X ] Enhancement
[ ] Bug

@kivaisan
Copy link
Contributor

Thanks. We'll check this.
Internal issue: IOTCELL-994

@0xc0170
Copy link
Contributor

0xc0170 commented May 17, 2018

This should fix it #6905

@mattbrown015
Copy link
Contributor Author

Closing as appears to be fixed.

I updated to https://github.com/ARMmbed/mbed-os/#3bcc076c0c08a4f411bfbeb9fcf173bb1343cd8c today, removed "target.features_add": ["COMMON_PAL"] from mbed_app.json and didn't notice any change in the LoRaWAN trace.

Thanks.

@kivaisan
Copy link
Contributor

Please note that I still have a PR pending for lorawan example application and I will merge it after mbed-os 5.8.5 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants