Skip to content

DeviceKey made Mbed TLS Configuration changes that haven't been upstreamed #7142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonbutcher opened this issue Jun 6, 2018 · 5 comments

Comments

@simonbutcher
Copy link
Contributor

Description

PR #6642 - "Device key implementation" made modifications to Mbed TLS configuration files (such as features/mbedtls/inc/mbedtls/config.h) but those modifications have not been upstreamed to the Mbed TLS repository, meaning when we import the next release of Mbed TLS, those changes will be lost.

This needs immediate correction to ensure the changes aren't lost with the next Mbed TLS release.

Issue request type

[ ] Question
[ ] Enhancement
[X ] Bug

cc: @k-stachowiak

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 6, 2018

@yossi2le

@ciarmcom
Copy link
Member

ciarmcom commented Jun 6, 2018

ARM Internal Ref: IOTSSL-2345

@yossi2le
Copy link
Contributor

yossi2le commented Jun 6, 2018

@sbutcher-arm Hi,
I need just a short explanation of how to do it. What is the correct repository of the mbed-tls that i should fork from?

@simonbutcher
Copy link
Contributor Author

This issue was resolved by PR #7144 'Add configuration options to enable CMAC in mbedtls by default' and PR #7135 'Update Mbed TLS to version 2.10.0'. I think it can now be closed.

@yossi2le - Changes to Mbed TLS should be upstreamed to Mbed TLS. However, the DeviceKey change didn't need to do that, just change the import script, which is what #7144 does.

@yossi2le
Copy link
Contributor

@sbutcher-arm
Thanks for the info, everyday learning something new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants