Skip to content

Fix python module versions within requirements.txt #8396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmonr opened this issue Oct 11, 2018 · 7 comments · Fixed by #8542
Closed

Fix python module versions within requirements.txt #8396

cmonr opened this issue Oct 11, 2018 · 7 comments · Fixed by #8542

Comments

@cmonr
Copy link
Contributor

cmonr commented Oct 11, 2018

Description

After finding and solving an issue with colorama being updated (resolved with #8390), @studavekar brought up a good comment that we should do the same with other packages.

Requirements.txt should be fixed to specific versions, and have a process to update versions on a regular bases. This issue is for the first part of the problem, with @ARMmbed/mbed-os-test already working on the second.

Issue request type

[ ] Question
[x] Enhancement
[ ] Bug

@OPpuolitaival
Copy link
Contributor

I think that this make things a lot easier because now it is not easy to track when tools versions are updated. When there are specific version then PR itself is used to test the new version of the tool

@cmonr
Copy link
Contributor Author

cmonr commented Oct 16, 2018

Aaand it looks like we just got hit again by not having versions fixed/pinned.

Last working master build: https://travis-ci.org/ARMmbed/mbed-os/builds/442254105
The next build after: https://travis-ci.org/ARMmbed/mbed-os/builds/442300780

(urllib3 was updated from 1.23 to 1.24)

@ciarmcom
Copy link
Member

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-30

@yennster
Copy link
Contributor

@cmonr Does #8446 fix this issue?

@studavekar
Copy link
Contributor

@yennster this issue is to review https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt and update to latest working version. As of now, most of packages say >= which are causing failures as latest version of module may not be compatible with other modules used.

problem seen

  1. htrun fails with mbedgt: cannot import name MbedBoard htrun#222
  2. Pin urllib3 pip module in requirements.txt #8446

@cmonr
Copy link
Contributor Author

cmonr commented Oct 23, 2018

@yennster Not completely.

#8466 was the immediate fix needed to make master green again, but this ticket is a placeholder to make sure that we update requirements.txt so that all module versions are updated accordingly.

Feel free to assign the internal ticket to me.

@yennster
Copy link
Contributor

@cmonr Moved to IOTCORE and assigned it to you (IOTCORE-571)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants