Skip to content

apply FatFs 0.13b hotfix - fix readdir() never terminates when dir is full #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2018
Merged

apply FatFs 0.13b hotfix - fix readdir() never terminates when dir is full #7412

merged 1 commit into from
Jul 9, 2018

Conversation

bmcdonnell-ionx
Copy link
Contributor

Description

Apply this patch...
http://elm-chan.org/fsw/ff/patches.html
http://elm-chan.org/fsw/ff/ff13b_p1.diff

...to resolve the final issue remaining [1] on #5780.

The issue is that when a FAT FS directory is full, readdir() would never return NULL to terminate the listing.

Cherry-picked onto mbed-os-5.9.2 for testing. Tested with LPC4088.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested review from deepikabhavnani and a team July 4, 2018 07:30
@dannybenor
Copy link

@yossi2le can you please review?

@yossi2le
Copy link
Contributor

yossi2le commented Jul 4, 2018

@bmcdonnell-ionx thanks for that.
This is the exact implemetation by ChaN (http://elm-chan.org/fsw/ff/patches.html) for the bug described in issue #5780. Looks good to me.

yossi2le
yossi2le approved these changes Jul 4, 2018
View reviewed changes
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

deepikabhavnani
deepikabhavnani approved these changes Jul 5, 2018
View reviewed changes
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmcdonnell-ionx Thanks for the fix 👍

@cmonr
Copy link
Contributor

cmonr commented Jul 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 5, 2018

Build : SUCCESS

Build number : 2542
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7412/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

Test : FAILURE

Build number : 2297
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7412/2297

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

Exporter Build : SUCCESS

Build number : 2186
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7412/

@cmonr
Copy link
Contributor

cmonr commented Jul 6, 2018

Test failure doesn't seem related.
/morph test

@cmonr
Copy link
Contributor

cmonr commented Jul 6, 2018

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

Test : SUCCESS

Build number : 2306
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7412/2306

@cmonr cmonr merged commit 8f43223 into ARMmbed:master Jul 9, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7412 from bmcdonnell-ionx/bugfix-fatfs-dir…
b7dcd6d 
…-list-when-full

apply FatFs 0.13b hotfix - fix readdir() never terminates when dir is full
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

@yossi2le yossi2le yossi2le approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bmcdonnell-ionx @dannybenor @yossi2le @cmonr @mbed-ci @deepikabhavnani @0xc0170