From 5e8c7d2fd417138afe6d9939334e0b6edaa14f28 Mon Sep 17 00:00:00 2001 From: Jari Poyhonen Date: Mon, 28 Jan 2019 15:21:36 +0200 Subject: [PATCH 1/6] Cellular: add TC test_AT_CellularSIM_set_pin_verify_debug and FC --- .../AT/at_cellularsim/at_cellularsimtest.cpp | 16 ++++++++++++++ UNITTESTS/stubs/ATHandler_stub.cpp | 21 +++++++++++++++++++ UNITTESTS/stubs/ATHandler_stub.h | 5 +++++ features/cellular/framework/AT/ATHandler.cpp | 5 +++++ features/cellular/framework/AT/ATHandler.h | 7 +++++++ .../cellular/framework/AT/AT_CellularSIM.cpp | 7 +++++++ 6 files changed, 61 insertions(+) diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp index e4fe6a1ce10..ad9c7e8965d 100644 --- a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp +++ b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp @@ -59,6 +59,22 @@ TEST_F(TestAT_CellularSIM, Create) delete sim; } +TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin_verify_debug) +{ + EventQueue que; + FileHandle_stub fh1; + ATHandler at(&fh1, que, 0, ","); + + AT_CellularSIM sim(at); + ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; + at.set_debug(true); + EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin("12")); + + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_TRUE(at.get_debug()); +} + TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin) { EventQueue que; diff --git a/UNITTESTS/stubs/ATHandler_stub.cpp b/UNITTESTS/stubs/ATHandler_stub.cpp index 5ae5d4fca68..b73b94c0606 100644 --- a/UNITTESTS/stubs/ATHandler_stub.cpp +++ b/UNITTESTS/stubs/ATHandler_stub.cpp @@ -57,6 +57,19 @@ int ATHandler_stub::urc_amount = 0; mbed::Callback ATHandler_stub::callback[kATHandler_urc_table_max_size]; char *ATHandler_stub::urc_string_table[kATHandler_urc_table_max_size]; +bool ATHandler_stub::get_debug_flag = false; +uint8_t ATHandler_stub::set_debug_call_count = 0; + +bool ATHandler_stub::is_get_debug_run() +{ + return ATHandler_stub::get_debug_flag; +} + +uint8_t ATHandler_stub::set_debug_call_count_get() +{ + return ATHandler_stub::set_debug_call_count; +} + ATHandler::ATHandler(FileHandle *fh, EventQueue &queue, uint32_t timeout, const char *output_delimiter, uint16_t send_delay) : _nextATHandler(0), _fileHandle(fh), @@ -76,9 +89,17 @@ ATHandler::ATHandler(FileHandle *fh, EventQueue &queue, uint32_t timeout, const void ATHandler::set_debug(bool debug_on) { + ++ATHandler_stub::set_debug_call_count; ATHandler_stub::debug_on = debug_on; } +bool ATHandler::get_debug() const +{ + ATHandler_stub::get_debug_flag = true; + + return ATHandler_stub::debug_on; +} + ATHandler::~ATHandler() { ATHandler_stub::ref_count = kATHandler_destructor_ref_ount; diff --git a/UNITTESTS/stubs/ATHandler_stub.h b/UNITTESTS/stubs/ATHandler_stub.h index e243e355ba0..67d3b2649fa 100644 --- a/UNITTESTS/stubs/ATHandler_stub.h +++ b/UNITTESTS/stubs/ATHandler_stub.h @@ -62,6 +62,11 @@ extern int resp_stop_success_count; extern bool process_oob_urc; extern int urc_amount; extern char *urc_string_table[kATHandler_urc_table_max_size]; + +extern bool get_debug_flag; +bool is_get_debug_run(); +extern uint8_t set_debug_call_count; +uint8_t set_debug_call_count_get(); } #endif diff --git a/features/cellular/framework/AT/ATHandler.cpp b/features/cellular/framework/AT/ATHandler.cpp index 6da6dc9c564..8706f508585 100644 --- a/features/cellular/framework/AT/ATHandler.cpp +++ b/features/cellular/framework/AT/ATHandler.cpp @@ -116,6 +116,11 @@ void ATHandler::set_debug(bool debug_on) _debug_on = debug_on; } +bool ATHandler::get_debug() const +{ + return _debug_on; +} + ATHandler::~ATHandler() { while (_oobs) { diff --git a/features/cellular/framework/AT/ATHandler.h b/features/cellular/framework/AT/ATHandler.h index c5757d2f87c..313f93b2be3 100644 --- a/features/cellular/framework/AT/ATHandler.h +++ b/features/cellular/framework/AT/ATHandler.h @@ -434,6 +434,13 @@ class ATHandler { */ void set_debug(bool debug_on); + /** + * Get degug state set by @ref set_debug + * + * @return current state of debug + */ + bool get_debug() const; + /** Set debug_on for all ATHandlers in the _atHandlers list * * @param debug_on Set true to enable debug traces diff --git a/features/cellular/framework/AT/AT_CellularSIM.cpp b/features/cellular/framework/AT/AT_CellularSIM.cpp index 86425a852a6..5512a5de881 100644 --- a/features/cellular/framework/AT/AT_CellularSIM.cpp +++ b/features/cellular/framework/AT/AT_CellularSIM.cpp @@ -89,7 +89,14 @@ nsapi_error_t AT_CellularSIM::set_pin(const char *sim_pin) _at.lock(); _at.cmd_start("AT+CPIN="); + + const bool stored_debug_state = _at.get_debug(); + _at.set_debug(false); + _at.write_string(sim_pin); + + _at.set_debug(stored_debug_state); + _at.cmd_stop_read_resp(); return _at.unlock_return_error(); } From af535c7ef0c1c5e6d36dd2810d1842d322740edd Mon Sep 17 00:00:00 2001 From: Jari Poyhonen Date: Mon, 28 Jan 2019 15:24:49 +0200 Subject: [PATCH 2/6] Cellular: clean TC test_AT_CellularSIM_set_pin --- .../cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp index ad9c7e8965d..f06dc9d814b 100644 --- a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp +++ b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp @@ -89,8 +89,6 @@ TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin) EXPECT_TRUE(NSAPI_ERROR_DEVICE_ERROR == sim.set_pin("12")); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; - ATHandler_stub::read_string_value = (char *)"READY"; - ATHandler_stub::ssize_value = 5; EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin("12")); EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin(NULL)); From 4140dfdcf049c452bb307e265e5e29d1b3380c42 Mon Sep 17 00:00:00 2001 From: Jari Poyhonen Date: Tue, 29 Jan 2019 10:54:45 +0200 Subject: [PATCH 3/6] Cellular: modify TC test_AT_CellularSIM_change_pin and FC --- .../AT/at_cellularsim/at_cellularsimtest.cpp | 38 +++++++++++++++++++ UNITTESTS/stubs/ATHandler_stub.cpp | 10 +++++ UNITTESTS/stubs/ATHandler_stub.h | 2 + .../cellular/framework/AT/AT_CellularSIM.cpp | 7 ++++ 4 files changed, 57 insertions(+) diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp index f06dc9d814b..6690c236e0c 100644 --- a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp +++ b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp @@ -67,6 +67,7 @@ TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin_verify_debug) AT_CellularSIM sim(at); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; + ATHandler_stub::debug_call_count_clear(); at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin("12")); @@ -102,13 +103,50 @@ TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_change_pin) AT_CellularSIM sim(at); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; + + ATHandler_stub::debug_call_count_clear(); + at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_OK == sim.change_pin("12", "34")); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_TRUE(at.get_debug()); + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(false); EXPECT_TRUE(NSAPI_ERROR_OK == sim.change_pin(NULL, "34")); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_FALSE(at.get_debug()); + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_OK == sim.change_pin("12", NULL)); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_TRUE(at.get_debug()); + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(false); EXPECT_TRUE(NSAPI_ERROR_OK == sim.change_pin(NULL, NULL)); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_FALSE(at.get_debug()); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_DEVICE_ERROR; + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_DEVICE_ERROR == sim.change_pin("12", "34")); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_TRUE(at.get_debug()); } TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin_query) diff --git a/UNITTESTS/stubs/ATHandler_stub.cpp b/UNITTESTS/stubs/ATHandler_stub.cpp index b73b94c0606..19830decbd1 100644 --- a/UNITTESTS/stubs/ATHandler_stub.cpp +++ b/UNITTESTS/stubs/ATHandler_stub.cpp @@ -65,11 +65,21 @@ bool ATHandler_stub::is_get_debug_run() return ATHandler_stub::get_debug_flag; } +void ATHandler_stub::get_debug_clear() +{ + ATHandler_stub::get_debug_flag = false; +} + uint8_t ATHandler_stub::set_debug_call_count_get() { return ATHandler_stub::set_debug_call_count; } +void ATHandler_stub::debug_call_count_clear() +{ + ATHandler_stub::set_debug_call_count = 0; +} + ATHandler::ATHandler(FileHandle *fh, EventQueue &queue, uint32_t timeout, const char *output_delimiter, uint16_t send_delay) : _nextATHandler(0), _fileHandle(fh), diff --git a/UNITTESTS/stubs/ATHandler_stub.h b/UNITTESTS/stubs/ATHandler_stub.h index 67d3b2649fa..3c0740ab887 100644 --- a/UNITTESTS/stubs/ATHandler_stub.h +++ b/UNITTESTS/stubs/ATHandler_stub.h @@ -65,8 +65,10 @@ extern char *urc_string_table[kATHandler_urc_table_max_size]; extern bool get_debug_flag; bool is_get_debug_run(); +void get_debug_clear(); extern uint8_t set_debug_call_count; uint8_t set_debug_call_count_get(); +void debug_call_count_clear(); } #endif diff --git a/features/cellular/framework/AT/AT_CellularSIM.cpp b/features/cellular/framework/AT/AT_CellularSIM.cpp index 5512a5de881..f1fb51cebe7 100644 --- a/features/cellular/framework/AT/AT_CellularSIM.cpp +++ b/features/cellular/framework/AT/AT_CellularSIM.cpp @@ -106,8 +106,15 @@ nsapi_error_t AT_CellularSIM::change_pin(const char *sim_pin, const char *new_pi _at.lock(); _at.cmd_start("AT+CPWD="); _at.write_string("SC"); + + const bool stored_debug_state = _at.get_debug(); + _at.set_debug(false); + _at.write_string(sim_pin); _at.write_string(new_pin); + + _at.set_debug(stored_debug_state); + _at.cmd_stop_read_resp(); return _at.unlock_return_error(); } From b3373d78ac491c7e8b8d5ffd7f6d7536386ecda6 Mon Sep 17 00:00:00 2001 From: Jari Poyhonen Date: Tue, 29 Jan 2019 11:20:19 +0200 Subject: [PATCH 4/6] Cellular: add negative case for TC test_AT_CellularSIM_set_pin_verify_debug --- .../AT/at_cellularsim/at_cellularsimtest.cpp | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp index 6690c236e0c..bd60eb395a0 100644 --- a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp +++ b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp @@ -67,13 +67,23 @@ TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin_verify_debug) AT_CellularSIM sim(at); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); ATHandler_stub::debug_call_count_clear(); at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin("12")); - EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); EXPECT_TRUE(at.get_debug()); + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(false); + EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin("11")); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_FALSE(at.get_debug()); } TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin) @@ -104,6 +114,8 @@ TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_change_pin) AT_CellularSIM sim(at); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); ATHandler_stub::debug_call_count_clear(); at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_OK == sim.change_pin("12", "34")); From f93a2795950a83dd6a221d8d68908a5c1f2b330d Mon Sep 17 00:00:00 2001 From: Jari Poyhonen Date: Tue, 29 Jan 2019 11:41:30 +0200 Subject: [PATCH 5/6] Cellular: modify TC test_AT_CellularSIM_set_pin_query and FC --- .../AT/at_cellularsim/at_cellularsimtest.cpp | 32 ++++++++++++++++++- .../cellular/framework/AT/AT_CellularSIM.cpp | 14 ++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp index bd60eb395a0..f2d162667a9 100644 --- a/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp +++ b/UNITTESTS/features/cellular/framework/AT/at_cellularsim/at_cellularsimtest.cpp @@ -169,12 +169,42 @@ TEST_F(TestAT_CellularSIM, test_AT_CellularSIM_set_pin_query) AT_CellularSIM sim(at); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin_query("12", true)); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_TRUE(at.get_debug()); + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(false); EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin_query(NULL, true)); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_FALSE(at.get_debug()); - ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK; + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(true); EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin_query("12", false)); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_TRUE(at.get_debug()); + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(false); EXPECT_TRUE(NSAPI_ERROR_OK == sim.set_pin_query(NULL, false)); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_FALSE(at.get_debug()); ATHandler_stub::nsapi_error_value = NSAPI_ERROR_DEVICE_ERROR; EXPECT_TRUE(NSAPI_ERROR_DEVICE_ERROR == sim.set_pin_query("12", false)); diff --git a/features/cellular/framework/AT/AT_CellularSIM.cpp b/features/cellular/framework/AT/AT_CellularSIM.cpp index f1fb51cebe7..61f91c372e1 100644 --- a/features/cellular/framework/AT/AT_CellularSIM.cpp +++ b/features/cellular/framework/AT/AT_CellularSIM.cpp @@ -127,14 +127,28 @@ nsapi_error_t AT_CellularSIM::set_pin_query(const char *sim_pin, bool query_pin) _at.cmd_start("AT+CLCK="); _at.write_string("SC"); _at.write_int(1); + + const bool stored_debug_state = _at.get_debug(); + _at.set_debug(false); + _at.write_string(sim_pin); + + _at.set_debug(stored_debug_state); + _at.cmd_stop_read_resp(); } else { /* use the SIM unlocked */ _at.cmd_start("AT+CLCK="); _at.write_string("SC"); _at.write_int(0); + + const bool stored_debug_state = _at.get_debug(); + _at.set_debug(false); + _at.write_string(sim_pin); + + _at.set_debug(stored_debug_state); + _at.cmd_stop_read_resp(); } return _at.unlock_return_error(); From 240c784f1066b51bc55ed8c2e14ee4301db06a0c Mon Sep 17 00:00:00 2001 From: Jari Poyhonen Date: Tue, 29 Jan 2019 15:48:05 +0200 Subject: [PATCH 6/6] Cellular: modify TC connect_disconnect_sync and FC --- .../at_cellularcontexttest.cpp | 22 +++++++++++++++++++ .../framework/AT/AT_CellularContext.cpp | 7 ++++++ 2 files changed, 29 insertions(+) diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularcontext/at_cellularcontexttest.cpp b/UNITTESTS/features/cellular/framework/AT/at_cellularcontext/at_cellularcontexttest.cpp index 4d7b80cb98a..da96abb1ded 100644 --- a/UNITTESTS/features/cellular/framework/AT/at_cellularcontext/at_cellularcontexttest.cpp +++ b/UNITTESTS/features/cellular/framework/AT/at_cellularcontext/at_cellularcontexttest.cpp @@ -499,7 +499,29 @@ TEST_F(TestAT_CellularContext, connect_disconnect_sync) ASSERT_EQ(ctx1.disconnect(), NSAPI_ERROR_OK); EXPECT_TRUE(ctx1.is_connected() == false); + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(true); ASSERT_EQ(ctx1.connect("1234", "internet", "usern", "pwd"), NSAPI_ERROR_OK); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_TRUE(at.get_debug()); + EXPECT_TRUE(ctx1.is_connected() == true); + ASSERT_EQ(ctx1.disconnect(), NSAPI_ERROR_OK); + EXPECT_TRUE(ctx1.is_connected() == false); + + ATHandler_stub::get_debug_clear(); + EXPECT_FALSE(ATHandler_stub::is_get_debug_run()); + ATHandler_stub::debug_call_count_clear(); + at.set_debug(false); + ASSERT_EQ(ctx1.connect("1234", "internet", "usern", "pwd"), NSAPI_ERROR_OK); + EXPECT_TRUE(ATHandler_stub::is_get_debug_run()); + EXPECT_TRUE(ATHandler_stub::set_debug_call_count_get() == 3); + EXPECT_FALSE(at.get_debug()); + EXPECT_TRUE(ctx1.is_connected() == true); + ASSERT_EQ(ctx1.disconnect(), NSAPI_ERROR_OK); + EXPECT_TRUE(ctx1.is_connected() == false); // More connect test after we are re-writted getting of PDP context... } diff --git a/features/cellular/framework/AT/AT_CellularContext.cpp b/features/cellular/framework/AT/AT_CellularContext.cpp index 1cb280318f7..918123b1c8b 100644 --- a/features/cellular/framework/AT/AT_CellularContext.cpp +++ b/features/cellular/framework/AT/AT_CellularContext.cpp @@ -295,8 +295,15 @@ nsapi_error_t AT_CellularContext::do_user_authentication() _at.cmd_start("AT+CGAUTH="); _at.write_int(_cid); _at.write_int(_authentication_type); + + const bool stored_debug_state = _at.get_debug(); + _at.set_debug(false); + _at.write_string(_uname); _at.write_string(_pwd); + + _at.set_debug(stored_debug_state); + _at.cmd_stop_read_resp(); if (_at.get_last_error() != NSAPI_ERROR_OK) { return NSAPI_ERROR_AUTH_FAILURE;