Skip to content

Commit e2c12dc

Browse files
committed
Fix empty signature tooltip after function call (microsoft#616)
Fixes microsoft#614.
1 parent d5604d2 commit e2c12dc

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/LanguageServer/Impl/Sources/SignatureSource.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,16 @@ public async Task<SignatureHelp> GetSignatureAsync(IDocumentAnalysis analysis, S
8484
if (activeParameter >= 0) {
8585
// TODO: Better selection of active signature by argument set
8686
activeSignature = signatures
87-
.Select((s, i) => Tuple.Create(s, i))
88-
.OrderBy(t => t.Item1.parameters.Length)
89-
.FirstOrDefault(t => t.Item1.parameters.Length > activeParameter)
90-
?.Item2 ?? -1;
87+
.Select((s, i) => Tuple.Create(s, i))
88+
.OrderBy(t => t.Item1.parameters.Length)
89+
.FirstOrDefault(t => t.Item1.parameters.Length > activeParameter)
90+
?.Item2 ?? -1;
9191
}
9292

93+
activeSignature = activeSignature >= 0
94+
? activeSignature
95+
: (signatures.Length > 0 ? 0 : -1);
96+
9397
return new SignatureHelp {
9498
signatures = signatures.ToArray(),
9599
activeSignature = activeSignature,

0 commit comments

Comments
 (0)