removes memoization that sometimes causes stale data

Author: cammiida

src/features/formData/useDataModelBindings.ts

@@ -50,10 +50,7 @@ export function useDataModelBindings<B extends IDataModelBindings | undefined, D
   const isValid = FD.useBindingsAreValid(bindings);
   const { setValue, setValues } = useSaveDataModelBindings(bindings, debounceTimeout);
 
-  return useMemo(
-    () => ({ formData: formData as Output<B, DA>['formData'], setValue, setValues, isValid }),
-    [formData, isValid, setValue, setValues],
-  );
+  return { formData: formData as Output<B, DA>['formData'], setValue, setValues, isValid };
 }
 
 export function useSaveDataModelBindings<B extends IDataModelBindings | undefined>(

src/features/options/useGetOptions.ts

@@ -1,4 +1,4 @@
-import { useCallback, useEffect, useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 
 import { evalExpr } from 'src/features/expressions';
 import { ExprVal } from 'src/features/expressions/types';
@@ -78,26 +78,16 @@ export function useSetOptions(
   const { formData, setValue } = useDataModelBindings(dataModelBindings);
   const value = formData.simpleBinding ?? '';
 
-  const currentValues = useMemo(
-    () => (value && value.length > 0 ? (valueType === 'multi' ? value.split(',') : [value]) : []),
-    [value, valueType],
-  );
-
-  const selectedValues = useMemo(
-    () => currentValues.filter((value) => options.find((option) => option.value === value)),
-    [options, currentValues],
-  );
-
-  const setData = useCallback(
-    (values: string[]) => {
-      if (valueType === 'single') {
-        setValue('simpleBinding', values.at(0));
-      } else if (valueType === 'multi') {
-        setValue('simpleBinding', values.join(','));
-      }
-    },
-    [setValue, valueType],
-  );
+  const currentValues = value && value.length > 0 ? (valueType === 'multi' ? value.split(',') : [value]) : [];
+  const selectedValues = currentValues.filter((value) => options.find((option) => option.value === value));
+
+  function setData(values: string[]) {
+    if (valueType === 'single') {
+      setValue('simpleBinding', values.at(0));
+    } else if (valueType === 'multi') {
+      setValue('simpleBinding', values.join(','));
+    }
+  }
 
   return {
     rawData: value,