Skip to content

weird inconsistency between macos and ubuntu #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-mapper opened this issue Dec 31, 2015 · 6 comments
Open

weird inconsistency between macos and ubuntu #2

max-mapper opened this issue Dec 31, 2015 · 6 comments

Comments

@max-mapper
Copy link

I made a gist reproducible test case for ubuntu here: https://gist.github.com/maxogden/0ea1f28b977c79a7a2cf

on macos both a and b from the gist behave as expected. however, on ubuntu b never emits close

@okdistribute
Copy link

If you replace /bin/sh with /bin/bash on ubuntu, the child_process successfully emits the close event.. could this be related to nodejs/node#4432?

@AndreasMadsen
Copy link
Owner

I'm a bit busy, so I'm going to wait for a solution to nodejs/node#4432. If you have good solution fell free to tell me or make a pull request.

@okdistribute
Copy link

@AndreasMadsen alright I made a PR here, #3

@AndreasMadsen
Copy link
Owner

Added support for the shell option. So at least you can do:

execspawn(command, { shell: process.platform === 'win32' ? 'cmd.exe' : '/bin/bash' });

@max-mapper
Copy link
Author

@AndreasMadsen
Copy link
Owner

@maxogden Lovely. Hopefully we will see a solution from node core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants