-
Notifications
You must be signed in to change notification settings - Fork 2
weird inconsistency between macos and ubuntu #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you replace /bin/sh with /bin/bash on ubuntu, the child_process successfully emits the |
I'm a bit busy, so I'm going to wait for a solution to nodejs/node#4432. If you have good solution fell free to tell me or make a pull request. |
@AndreasMadsen alright I made a PR here, #3 |
Added support for the execspawn(command, { shell: process.platform === 'win32' ? 'cmd.exe' : '/bin/bash' }); |
@AndreasMadsen yay thanks, we are green on travis now :) https://travis-ci.org/maxogden/dat/jobs/100433170 heres my hack: https://github.com/maxogden/dat/blob/master/tests/helpers/spawn.js |
@maxogden Lovely. Hopefully we will see a solution from node core. |
I made a gist reproducible test case for ubuntu here: https://gist.github.com/maxogden/0ea1f28b977c79a7a2cf
on macos both
a
andb
from the gist behave as expected. however, on ubuntub
never emits closeThe text was updated successfully, but these errors were encountered: