Skip to content

Listener to hear when file stalls on upload. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2012

Conversation

gailh
Copy link
Contributor

@gailh gailh commented Jan 17, 2012

Added listener to hear when the file stalls on upload. Currently it can get stuck in the while loop indefinitely or take a really long time if the connection is really slow. So this can check when nothing happens on the connection for a while.

@jfarcand
Copy link
Contributor

Salut, seems to have a tab problem so it makes it hard to see what really changed. If you have the cycle, can you redo the pull. Will looks tomorrow. Thanks!

@gailh
Copy link
Contributor Author

gailh commented Jan 17, 2012

I think that I fixed the File Part that had so serious tab issues. Let me know if that didn't work.

Gail

@jfarcand
Copy link
Contributor

Salut,

   Copyright (c) 2000-2011 Liferay, Inc. All rights reserved.

Should it be the normal Sonatype/Apache 2 license. Also, since you are contributing more and more (yeahhh), it would be nice if you could sign the CLA.

 http://m2eclipse.sonatype.org/getting-involved.html

Thanks!!!

@gailh
Copy link
Contributor Author

gailh commented Jan 20, 2012

Yes that is an oversight on my part it should be the standard Sonatype/Apache 2 license.

@gailh
Copy link
Contributor Author

gailh commented Jan 20, 2012

Do I need to resend the pull request?

@jfarcand
Copy link
Contributor

No, I will make the change locally. But I still think you will need to sign the CLA ... usually I don't ask for it if changes are less than ~100 lines ... but your contribution is more now :-) Thanks!

@gailh
Copy link
Contributor Author

gailh commented Jan 20, 2012

I will sign and send the license agreement this morning. .

@jfarcand
Copy link
Contributor

Salut, let me know once you have send the CLA, I will go ahead and merge. I'm planning to cut 1.7.1 soon with your fixes BTW.

@jfarcand jfarcand merged commit db8e48c into AsyncHttpClient:master Jan 24, 2012
@jfarcand
Copy link
Contributor

Well, looks like I already merged and wrongly pushed. Anyway let me know once you have send the document
Thanks!

@gailh
Copy link
Contributor Author

gailh commented Jan 24, 2012

I sent the document (via email and snail mail) last week and have gotten it
back from you with the other signatures.

Is there something else I need to do?

Thanks!

Gail

On Tue, Jan 24, 2012 at 11:22 AM, Jeanfrancois Arcand <
[email protected]

wrote:

Well, looks like I already merged and wrongly pushed. Anyway let me know
once you have send the document
Thanks!


Reply to this email directly or view it on GitHub:
https://github.com/sonatype/async-http-client/pull/41#issuecomment-3638551

Thanks!

Gail

Nordic Symposium
25 April 2012
Register today: www.liferay.com/nordic2012

@jfarcand
Copy link
Contributor

Great! Nothing to do. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants