Fixes Toufool#86 Stop uncaught exceptions from silently crashing the app

Author: Avasam

src/AutoSplit.py

@@ -1,7 +1,8 @@
 #!/usr/bin/python3.9
 # -*- coding: utf-8 -*-
-from types import FunctionType
-from typing import Callable, List, Optional
+import traceback
+from types import FunctionType, TracebackType
+from typing import Callable, List, Optional, Type
 
 from copy import copy
 from PyQt6 import QtCore, QtGui, QtTest, QtWidgets
@@ -1197,22 +1198,47 @@ def exit():
 
 def main():
     app = QtWidgets.QApplication(sys.argv)
-    app.setWindowIcon(QtGui.QIcon(':/resources/icon.ico'))
-
-    main_window = AutoSplit()
-    main_window.show()
-    if main_window.actionCheck_for_Updates_on_Open.isChecked():
-        checkForUpdates(main_window, check_for_updates_on_open=True)
+    try:
+        app.setWindowIcon(QtGui.QIcon(':/resources/icon.ico'))
+        main_window = AutoSplit()
+        main_window.show()
+        # Needs to be after main_window.show() to be shown over
+        if main_window.actionCheck_for_Updates_on_Open.isChecked():
+            checkForUpdates(main_window, check_for_updates_on_open=True)
+
+        # Kickoff the event loop every so often so we can handle KeyboardInterrupt (^C)
+        timer = QtCore.QTimer()
+        timer.timeout.connect(lambda: None)
+        timer.start(500)
+
+        exit_code = app.exec()
+    except Exception as exception:
+        # Print error to console if not running in executable
+        if getattr(sys, 'frozen', False):
+            error_messages.exceptionTraceback(
+                "AutoSplit encountered an unrecoverable exception and will now close itself.<br/>"
+                "Please copy the following message over at<br/>"
+                "<a href='https://github.com/Toufool/Auto-Split/issues'>github.com/Toufool/Auto-Split/issues</a>",
+                exception)
+        else:
+            traceback.print_exception(type(exception), exception, exception.__traceback__)
+        sys.exit(1)
 
-    # Kickoff the event loop every so often so we can handle KeyboardInterrupt (^C)
-    timer = QtCore.QTimer()
-    timer.timeout.connect(lambda: None)
-    timer.start(500)
     # Catch Keyboard Interrupts for a clean close
-    signal.signal(signal.SIGINT, lambda _,  __: sys.exit(app))
+    signal.signal(signal.SIGINT, lambda _,  __: sys.exit(exit_code))
+
+    sys.exit(exit_code)
+
 
-    sys.exit(app.exec())
+def excepthook(type: Type[BaseException], exception: BaseException, traceback: Optional[TracebackType]):
+    error_messages.exceptionTraceback(
+            "AutoSplit encountered an unhandled exception and will try to recover, "
+            "however, things may not work quite right.<br/>"
+            "Please copy the following message over at<br/>"
+            "<a href='https://github.com/Toufool/Auto-Split/issues'>github.com/Toufool/Auto-Split/issues</a>",
+            exception)
 
 
 if __name__ == '__main__':
+    sys.excepthook = excepthook
     main()

src/capture_windows.py

@@ -55,6 +55,8 @@ def __get_image(hwnd: int, rect: RECT, print_window: bool = False):
         # Causes a 10-15x performance drop. But allows recording hardware accelerated windows
         if (print_window):
             windll.user32.PrintWindow(hwnd, dcObject.GetSafeHdc(), PW_RENDERFULLCONTENT)
+        else:
+            windll.user32.PrintWindow(hwnd, dcObject.GetSafeHdc())
 
         compatibleDC = dcObject.CreateCompatibleDC()
         bitmap: HBITMAP = win32ui.CreateBitmap()

src/error_messages.py

@@ -1,12 +1,20 @@
 # Error messages
-from PyQt6 import QtWidgets
+import traceback
+from PyQt6 import QtCore, QtWidgets
 
 
-def setTextMessage(message: str):
-    msgBox = QtWidgets.QMessageBox()
-    msgBox.setWindowTitle('Error')
-    msgBox.setText(message)
-    msgBox.exec()
+def setTextMessage(message: str, details: str = ''):
+    messageBox = QtWidgets.QMessageBox()
+    messageBox.setWindowTitle('Error')
+    messageBox.setTextFormat(QtCore.Qt.TextFormat.RichText)
+    messageBox.setText(message)
+    if details:
+        messageBox.setDetailedText(details)
+        for button in messageBox.buttons():
+            if messageBox.buttonRole(button) == QtWidgets.QMessageBox.ButtonRole.ActionRole:
+                button.click()
+                break
+    messageBox.exec()
 
 
 def splitImageDirectoryError():
@@ -83,3 +91,9 @@ def checkForUpdatesError():
 
 def stdinLostError():
     setTextMessage("stdin not supported or lost, external control like LiveSplit integration will not work.")
+
+
+def exceptionTraceback(message: str, exception: Exception):
+    setTextMessage(
+        message,
+        "\n".join(traceback.format_exception(None, exception, exception.__traceback__)))