Skip to content

Splitting the operations in two clients and have clients in different namespace #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msyyc opened this issue Jan 3, 2023 · 0 comments · Fixed by #1649
Closed

Splitting the operations in two clients and have clients in different namespace #1647

msyyc opened this issue Jan 3, 2023 · 0 comments · Fixed by #1649
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.

Comments

@msyyc
Copy link
Member

msyyc commented Jan 3, 2023

When trying Splitting the operations in two clients and have clients in different namespace, I find that current cadl-python can't handle it directly.

There are two bugs in generated code:
(1) wrong import

When referring to models in completion/_operations.py, the relative path shall be ... instead of ..:
f89a946#diff-593f9c3ac94b68a7e8f3f0d0564b21ecaf457c6caa12a39e1ca65fac0023e974
(2) wrong config name in _vendor.py

from ._configuration import EmbeddingClientConfiguration

it shall be :

from ._configuration import CompletionClientConfiguration
@msyyc msyyc added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jan 3, 2023
@msyyc msyyc self-assigned this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant