Skip to content

Add durable methods to app object in v4 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ejizba opened this issue Aug 24, 2022 · 2 comments
Closed

Add durable methods to app object in v4 #8

ejizba opened this issue Aug 24, 2022 · 2 comments
Assignees
Labels
feature P1 v4 🚀 We no longer use this label since v4 is now the default model.
Milestone

Comments

@ejizba
Copy link
Contributor

ejizba commented Aug 24, 2022

Specifically this issue is about adding the app.durable methods that will provide nice intellisense about the trigger options when registering a function.

Support in the durable package (the part that makes durable actually run locally) is tracked here: Azure/azure-functions-durable-js#384

@ejizba ejizba added v4 🚀 We no longer use this label since v4 is now the default model. P1 feature labels Aug 24, 2022
@ejizba ejizba changed the title Support durable in v4 Add durable methods to app object in v4 Sep 2, 2022
@ejizba
Copy link
Contributor Author

ejizba commented Sep 2, 2022

There have been discussions offline about where to put the app.durable methods (in this package or the durable package). I had assumed they would be in this package, which is why the original issue was created here. I think I mostly assumed that because all the other important bindings will be here, but durable is pretty unique with its own sdk so 🤷‍♂️. Curious to hear the reasons for putting those methods in the durable package

Fwiw, I don't think it'll be that difficult either way. We would not drastically change anything in this module. Rather, the durable package would just provide wrappers around the app.generic method if they want to provide durable methods from their own package

I do think it increases discoverability if those methods are in this package as we focused on intellisense a lot in the new model and they would need to be in this package to show up when a user types app. by default.

cc @davidmrdavid

@ejizba ejizba added this to the September 2022 milestone Sep 6, 2022
@ejizba ejizba modified the milestones: September 2022, November 2022 Oct 31, 2022
@ejizba ejizba modified the milestones: November 2022, December 2022 Nov 30, 2022
@ejizba
Copy link
Contributor Author

ejizba commented Jan 12, 2023

Moved to durable repo and merged in Azure/azure-functions-durable-js#399

@ejizba ejizba closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature P1 v4 🚀 We no longer use this label since v4 is now the default model.
Projects
None yet
Development

No branches or pull requests

2 participants