Skip to content

Improve default of toTypedData method (converting protobuf messages => JavaScript) #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhoeger opened this issue Dec 2, 2019 · 1 comment
Closed

Improve default of toTypedData method (converting protobuf messages => JavaScript) #267

mhoeger opened this issue Dec 2, 2019 · 1 comment
Assignees
@ejizba
Labels
engineering enhancement P3
Milestone
August 2022

Comments

@mhoeger
Copy link
Contributor

mhoeger commented Dec 2, 2019

Issue raised in this PR: #263

What will happen in case the type is not defined in these if, specially there is no else default case? This case should not ever happen.

We should change the default to something more helpful than doing nothing
@mhoeger mhoeger self-assigned this Dec 2, 2019
@mhoeger mhoeger mentioned this issue Dec 2, 2019
Merged
@ejizba ejizba added this to the Backlog Candidates milestone Jan 28, 2022
@ejizba ejizba self-assigned this Sep 12, 2022
@ejizba ejizba modified the milestones: August 2022, September 2022 Sep 12, 2022
@ejizba
Copy link
Contributor

ejizba commented Nov 30, 2022

Addressed by Azure/azure-functions-nodejs-library@efa5fb3

@ejizba ejizba closed this as completed Nov 30, 2022
@ejizba ejizba modified the milestones: September 2022, August 2022 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejizba ejizba

Labels
engineering enhancement P3
Projects
None yet
Milestone
August 2022
Development

No branches or pull requests
2 participants
@mhoeger @ejizba