Skip to content

Commit 5525dc8

Browse files
Update wording and severity for the 'Downloading Managed Dependencies message' (#403)
1 parent 5267b2c commit 5525dc8

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/DependencyManagement/DependencyManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ public bool WaitForDependenciesAvailability(Func<ILogger> getLogger)
152152
}
153153

154154
var logger = getLogger();
155-
logger.Log(isUserOnlyLog: true, LogLevel.Information, PowerShellWorkerStrings.DependencyDownloadInProgress);
155+
logger.Log(isUserOnlyLog: true, LogLevel.Warning, PowerShellWorkerStrings.DependencyDownloadInProgress);
156156
WaitOnDependencyInstallationTask();
157157
return true;
158158
}

src/resources/PowerShellWorkerStrings.resx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@
5959
: using a System.ComponentModel.TypeConverter
6060
: and then encoded with base64 encoding.
6161
-->
62-
<xsd:schema id="root" xmlns="" xmlns:xsd="https://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
63-
<xsd:import namespace="https://www.w3.org/XML/1998/namespace" />
62+
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
63+
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
6464
<xsd:element name="root" msdata:IsDataSet="true">
6565
<xsd:complexType>
6666
<xsd:choice maxOccurs="unbounded">
@@ -209,7 +209,7 @@
209209
<value>A new PowerShell manager instance is added to the pool. Current pool size '{0}'.</value>
210210
</data>
211211
<data name="DependencyDownloadInProgress" xml:space="preserve">
212-
<value>Managed dependency download is in progress, function execution will continue when it's done.</value>
212+
<value>The first managed dependency download is in progress, function execution will continue when it's done. Subsequent updates will be performed in the background.</value>
213213
</data>
214214
<data name="OutputBindingAlreadySet" xml:space="preserve">
215215
<value>The output binding '{0}' is already set with a value. The type of the output binding is '{1}'. It only accepts one message/record/file per a Function invocation. To override the value, use '-Clobber'.</value>

test/Unit/DependencyManagement/DependencyManagerTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public void StartDependencyInstallationIfNeeded_InstallsSnapshotInForeground_Whe
150150
var hadToWait = dependencyManager.WaitForDependenciesAvailability(() => _mockLogger.Object);
151151

152152
Assert.True(hadToWait);
153-
VerifyMessageLogged(LogLevel.Information, PowerShellWorkerStrings.DependencyDownloadInProgress, expectedIsUserLog: true);
153+
VerifyMessageLogged(LogLevel.Warning, PowerShellWorkerStrings.DependencyDownloadInProgress, expectedIsUserLog: true);
154154
VerifyExactlyOneSnapshotInstalled();
155155
}
156156
}
@@ -225,7 +225,7 @@ public void StartDependencyInstallationIfNeeded_InstallsSnapshotInForeground_Whe
225225
var hadToWait = dependencyManager.WaitForDependenciesAvailability(() => _mockLogger.Object);
226226

227227
Assert.True(hadToWait);
228-
VerifyMessageLogged(LogLevel.Information, PowerShellWorkerStrings.DependencyDownloadInProgress, expectedIsUserLog: true);
228+
VerifyMessageLogged(LogLevel.Warning, PowerShellWorkerStrings.DependencyDownloadInProgress, expectedIsUserLog: true);
229229
VerifyExactlyOneSnapshotInstalled();
230230
}
231231
}

0 commit comments

Comments
 (0)