Skip to content

Commit a7f0db1

Browse files
committed
Use int.MaxValue for gRPC message size limit (#424)
Use int.MaxValue for gRPC message size limit instead of grpcMaxMessageLength command line argument
1 parent 9529fef commit a7f0db1

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/Messaging/MessagingStream.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ internal class MessagingStream
1717
private readonly AsyncDuplexStreamingCall<StreamingMessage, StreamingMessage> _call;
1818
private readonly SemaphoreSlim _semaphoreSlim = new SemaphoreSlim(initialCount: 1, maxCount: 1);
1919

20-
internal MessagingStream(string host, int port, int maxMessageLength)
20+
internal MessagingStream(string host, int port)
2121
{
22+
const int maxMessageLength = int.MaxValue;
23+
2224
var channelOptions = new []
2325
{
2426
new ChannelOption(ChannelOptions.MaxReceiveMessageLength, maxMessageLength),

src/Worker.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public async static Task Main(string[] args)
3535
.WithParsed(ops => arguments = ops)
3636
.WithNotParsed(err => Environment.Exit(1));
3737

38-
var msgStream = new MessagingStream(arguments.Host, arguments.Port, arguments.MaxMessageLength);
38+
var msgStream = new MessagingStream(arguments.Host, arguments.Port);
3939
var requestProcessor = new RequestProcessor(msgStream);
4040

4141
// Send StartStream message
@@ -63,7 +63,7 @@ internal class WorkerArguments
6363
[Option("requestId", Required = true, HelpText = "Request ID used for gRPC communication with the Host.")]
6464
public string RequestId { get; set; }
6565

66-
[Option("grpcMaxMessageLength", Required = true, HelpText = "gRPC Maximum message size.")]
66+
[Option("grpcMaxMessageLength", Required = false, HelpText = "[Deprecated and ignored] gRPC Maximum message size.")]
6767
public int MaxMessageLength { get; set; }
6868
}
6969
}

0 commit comments

Comments
 (0)