From 333e99e1d3e118fef5e45ce577c117181e15ff42 Mon Sep 17 00:00:00 2001 From: Anatoli Beliaev Date: Mon, 9 Mar 2020 14:21:41 -0700 Subject: [PATCH] Use int.MaxValue for gRPC message size limit Use int.MaxValue for gRPC message size limit instead of grpcMaxMessageLength command line argument --- src/Messaging/MessagingStream.cs | 4 +++- src/Worker.cs | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Messaging/MessagingStream.cs b/src/Messaging/MessagingStream.cs index 56789d29..82f1e108 100644 --- a/src/Messaging/MessagingStream.cs +++ b/src/Messaging/MessagingStream.cs @@ -17,8 +17,10 @@ internal class MessagingStream private readonly AsyncDuplexStreamingCall _call; private readonly SemaphoreSlim _semaphoreSlim = new SemaphoreSlim(initialCount: 1, maxCount: 1); - internal MessagingStream(string host, int port, int maxMessageLength) + internal MessagingStream(string host, int port) { + const int maxMessageLength = int.MaxValue; + var channelOptions = new [] { new ChannelOption(ChannelOptions.MaxReceiveMessageLength, maxMessageLength), diff --git a/src/Worker.cs b/src/Worker.cs index 17764ac7..093fcb3b 100644 --- a/src/Worker.cs +++ b/src/Worker.cs @@ -34,7 +34,7 @@ public async static Task Main(string[] args) .WithParsed(ops => arguments = ops) .WithNotParsed(err => Environment.Exit(1)); - var msgStream = new MessagingStream(arguments.Host, arguments.Port, arguments.MaxMessageLength); + var msgStream = new MessagingStream(arguments.Host, arguments.Port); var requestProcessor = new RequestProcessor(msgStream); // Send StartStream message @@ -62,7 +62,7 @@ internal class WorkerArguments [Option("requestId", Required = true, HelpText = "Request ID used for gRPC communication with the Host.")] public string RequestId { get; set; } - [Option("grpcMaxMessageLength", Required = true, HelpText = "gRPC Maximum message size.")] + [Option("grpcMaxMessageLength", Required = false, HelpText = "[Deprecated and ignored] gRPC Maximum message size.")] public int MaxMessageLength { get; set; } } }