Skip to content

Commit dc6610b

Browse files
authored
fix: 1.0.0a4: update version and revert abcmoduletrackermeta bug (#25)
* 1.0.0a4: update version and revert abcmoduletrackermeta bug * Update __init__.py
1 parent 2861dc2 commit dc6610b

File tree

4 files changed

+11
-33
lines changed

4 files changed

+11
-33
lines changed

azure-functions-extension-base/azure/functions/extension/base/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,4 @@
3939
"RequestSynchronizer",
4040
]
4141

42-
__version__ = "1.0.0a2"
42+
__version__ = "1.0.0a6"

azure-functions-extension-base/azure/functions/extension/base/web.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,21 +125,17 @@ def check_type(cls, pytype: type) -> bool:
125125
return False
126126

127127

128-
class ABCModuleTrackerMeta(abc.ABCMeta, ModuleTrackerMeta):
129-
pass
130-
131-
132-
class WebApp(metaclass=ABCModuleTrackerMeta):
128+
class WebApp(metaclass=ModuleTrackerMeta):
133129
@abstractmethod
134130
def route(self, func: Callable):
135131
raise NotImplementedError()
136132

137133
@abstractmethod
138134
def get_app(self):
139-
raise NotImplementedError()
135+
raise NotImplementedError() # pragma: no cover
140136

141137

142-
class WebServer(metaclass=ABCModuleTrackerMeta):
138+
class WebServer(metaclass=ModuleTrackerMeta):
143139
def __init__(self, hostname, port, web_app: WebApp):
144140
self.hostname = hostname
145141
self.port = port

azure-functions-extension-base/tests/test_meta.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def test_decode_typed_data(self):
193193

194194
# Case 7: attempt to coerce and pass
195195
datum_coerce_pass = meta.Datum(value=1, type="model_binding_data")
196-
self.assertEquals(
196+
self.assertEqual(
197197
meta._BaseConverter._decode_typed_data(datum_coerce_pass, python_type=str),
198198
"1",
199199
)

azure-functions-extension-base/tests/test_web.py

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -354,36 +354,18 @@ async def serve(self):
354354
self.assertEqual(server.port, 8080)
355355
self.assertEqual(server.web_app, "MockApp")
356356

357-
async def test_serve_method_raises_not_implemented_error(self):
358-
# Create a mock WebApp instance
359-
class MockWebApp(WebApp):
360-
def route(self, func):
361-
pass
362-
363-
def get_app(self):
364-
pass
365-
366-
class MockWebServer(WebServer):
367-
async def serve(self):
368-
super().serve()
369357

370-
# Create a WebServer instance with the mock WebApp
371-
server = MockWebServer("localhost", 8080, MockWebApp())
358+
class TestHttpV2Enabled(unittest.TestCase):
359+
def test_http_v2_enabled(self):
360+
ModuleTrackerMeta._module = None
372361

373-
# Ensure that calling the serve method raises NotImplementedError
374-
with self.assertRaises(NotImplementedError):
375-
await server.serve()
362+
class MockClass(metaclass=ModuleTrackerMeta):
363+
pass
376364

365+
MockClass()
377366

378-
class TestHttpV2Enabled(unittest.TestCase):
379-
@patch("azure.functions.extension.base.ModuleTrackerMeta.module_imported")
380-
def test_http_v2_enabled(self, mock_module_imported):
381-
mock_module_imported.return_value = True
382367
self.assertTrue(HttpV2FeatureChecker.http_v2_enabled())
383368

384-
mock_module_imported.return_value = False
385-
self.assertFalse(HttpV2FeatureChecker.http_v2_enabled())
386-
387369

388370
class TestResponseLabels(unittest.TestCase):
389371
def test_enum_values(self):

0 commit comments

Comments
 (0)