Skip to content

Fix publish SBOM manifest with nuget package and changing Win to Linux for release pipeline #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

arroyc
Copy link
Contributor

@arroyc arroyc commented Feb 9, 2022

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr changed the title fix pathing to publish sbom manifest with nuget package Fix publish SBOM manifest with nuget package and changing Win to Tux for release pipeline Feb 11, 2022
@vrdmr vrdmr marked this pull request as ready for review February 14, 2022 17:57
@arroyc arroyc changed the title Fix publish SBOM manifest with nuget package and changing Win to Tux for release pipeline Fix publish SBOM manifest with nuget package and changing Win to Linux for release pipeline Feb 14, 2022
@ghost ghost removed the needs-author feedback label Feb 14, 2022
@arroyc arroyc force-pushed the arroyc/fix-sbom-packaging branch 3 times, most recently from ac1231f to 354a65d Compare February 14, 2022 22:18
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #960 (5dfc1b6) into dev (8a450e9) will decrease coverage by 42.06%.
The diff coverage is n/a.

❗ Current head 5dfc1b6 differs from pull request most recent head c785dc8. Consider uploading reports for the commit c785dc8 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #960       +/-   ##
===========================================
- Coverage   81.04%   38.98%   -42.07%     
===========================================
  Files          35       35               
  Lines        2337     2337               
  Branches      370      370               
===========================================
- Hits         1894      911      -983     
- Misses        337     1392     +1055     
+ Partials      106       34       -72     
Flag Coverage Δ
unittests 38.93% <ø> (-42.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/functions.py 20.15% <0.00%> (-72.87%) ⬇️
azure_functions_worker/dispatcher.py 21.16% <0.00%> (-68.53%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
azure_functions_worker/utils/dependency.py 33.08% <0.00%> (-57.15%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) ⬇️
azure_functions_worker/extension.py 44.95% <0.00%> (-54.13%) ⬇️
...ared_memory_data_transfer/shared_memory_manager.py 26.80% <0.00%> (-51.55%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a450e9...c785dc8. Read the comment docs.

@arroyc arroyc force-pushed the arroyc/fix-sbom-packaging branch from 4aee702 to c785dc8 Compare February 17, 2022 17:46
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrdmr vrdmr merged commit 65c30d8 into dev Feb 17, 2022
@vrdmr vrdmr deleted the arroyc/fix-sbom-packaging branch February 17, 2022 22:34
@arroyc arroyc restored the arroyc/fix-sbom-packaging branch April 21, 2022 21:23
@vrdmr vrdmr deleted the arroyc/fix-sbom-packaging branch September 17, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants