Skip to content

OpenAPI specs that are not complete should not be in master #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devigned opened this issue Mar 22, 2016 · 6 comments
Closed

OpenAPI specs that are not complete should not be in master #195

devigned opened this issue Mar 22, 2016 · 6 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. internal-ms

Comments

@devigned
Copy link
Member

OpenAPI specs that are not 100% complete should not be included in the master branch. They should be off in a feature branch to ensure they are not included in code generation.

@brjohnstmsft you might have some feedback here as well.

@devigned devigned added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 22, 2016
@devigned
Copy link
Member Author

@amarzavery, you've been doing an awesome job with the reviews, thank you. Just wanted to bring this up and start a discussion about how we ensure the quality of the master branch.

@sphibbs and @tbombach pulling you in to provide some visibility here.

@Azure/adx-sdk-team

@devigned
Copy link
Member Author

@selvasingh you'll probably also have some feedback for this issue.

@devigned
Copy link
Member Author

#207 <-- is another example of this.

@NiklasGustafsson would you like to weigh in on this?

@brjohnstmsft
Copy link
Member

@devigned Is this proposed policy for ARM specs only, or does it include data plane specs as well?

@brjohnstmsft
Copy link
Member

@devigned @NiklasGustafsson Where did we land on this? I'd like to know whether or not I need to move the Search specs, and if so, which ones.

@salameer
Copy link
Member

salameer commented Oct 8, 2018

Closing this due to inactivity

@salameer salameer closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. internal-ms
Projects
None yet
Development

No branches or pull requests

5 participants