Skip to content

Commit a942d7a

Browse files
authored
[ServiceBus] allow optionally testing pyamqp (#37010)
* optional test pyamqp * fix failing flaky tests
1 parent 5806d25 commit a942d7a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

sdk/servicebus/azure-servicebus/tests/test_queues.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,7 +1151,7 @@ def test_queue_by_servicebus_client_receive_batch_with_retrieve_deadletter(self,
11511151
@pytest.mark.live_test_only
11521152
@CachedServiceBusResourceGroupPreparer(name_prefix='servicebustest')
11531153
@CachedServiceBusNamespacePreparer(name_prefix='servicebustest')
1154-
@CachedServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
1154+
@ServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
11551155
@pytest.mark.parametrize("uamqp_transport", uamqp_transport_params, ids=uamqp_transport_ids)
11561156
@ArgPasser()
11571157
def test_queue_by_servicebus_client_session_fail(self, uamqp_transport, *, servicebus_namespace=None, servicebus_queue=None, **kwargs):
@@ -2651,7 +2651,7 @@ def _hack_amqp_sender_run(self, **kwargs):
26512651
@pytest.mark.live_test_only
26522652
@CachedServiceBusResourceGroupPreparer(name_prefix='servicebustest')
26532653
@CachedServiceBusNamespacePreparer(name_prefix='servicebustest')
2654-
@CachedServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
2654+
@ServiceBusQueuePreparer(name_prefix='servicebustest', dead_lettering_on_message_expiration=True)
26552655
@pytest.mark.parametrize("uamqp_transport", uamqp_transport_params, ids=uamqp_transport_ids)
26562656
@ArgPasser()
26572657
def test_queue_send_large_message_receive(self, uamqp_transport, *, servicebus_namespace=None, servicebus_queue=None, **kwargs):

sdk/servicebus/azure-servicebus/tests/utilities.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
# temporary - disable uamqp if China b/c of 8+ hr runtime
1919
uamqp_available = uamqp_available and os.environ.get('SERVICEBUS_ENDPOINT_SUFFIX') != '.servicebus.chinacloudapi.cn'
20-
20+
test_pyamqp = os.environ.get('TEST_PYAMQP', 'true') == 'true'
2121

2222
def _get_default_handler():
2323
handler = logging.StreamHandler(stream=sys.stdout)
@@ -60,7 +60,7 @@ def sleep_until_expired(entity):
6060
time.sleep(max(0,(entity.locked_until_utc - utc_now()).total_seconds()+1))
6161

6262

63-
def uamqp_transport(use_uamqp=uamqp_available, use_pyamqp=True):
63+
def uamqp_transport(use_uamqp=uamqp_available, use_pyamqp=test_pyamqp):
6464
uamqp_transport_params = []
6565
uamqp_transport_ids = []
6666
if use_uamqp:

0 commit comments

Comments
 (0)