[Storage] Blobs Typing API View Feedback (#36654)

Author: vincenttran-msft

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

@@ -2043,7 +2043,7 @@ def stage_block_from_url(
     def get_block_list(
         self, block_list_type: str = "committed",
         **kwargs: Any
-    ) -> Tuple[List[Optional[BlobBlock]], List[Optional[BlobBlock]]]:
+    ) -> Tuple[List[BlobBlock], List[BlobBlock]]:
         """The Get Block List operation retrieves the list of blocks that have
         been uploaded as part of a block blob.
 
@@ -2067,7 +2067,7 @@ def get_block_list(
             see `here <https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/storage/azure-storage-blob
             #other-client--per-operation-configuration>`__.
         :returns: A tuple of two lists - committed and uncommitted blocks
-        :rtype: Tuple[List[Optional[BlobBlock]], List[Optional[BlobBlock]]]
+        :rtype: Tuple[List[BlobBlock], List[BlobBlock]]
         """
         access_conditions = get_access_conditions(kwargs.pop('lease', None))
         mod_conditions = get_modify_conditions(kwargs)
@@ -2286,7 +2286,7 @@ def set_blob_tags(self, tags: Optional[Dict[str, str]] = None, **kwargs: Any) ->
             process_storage_error(error)
 
     @distributed_trace
-    def get_blob_tags(self, **kwargs: Any) -> Optional[Dict[str, str]]:
+    def get_blob_tags(self, **kwargs: Any) -> Dict[str, str]:
         """The Get Tags operation enables users to get tags on a blob or specific blob version, or snapshot.
 
         .. versionadded:: 12.4.0
@@ -2309,13 +2309,13 @@ def get_blob_tags(self, **kwargs: Any) -> Optional[Dict[str, str]]:
             see `here <https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/storage/azure-storage-blob
             #other-client--per-operation-configuration>`__.
         :returns: Key value pairs of blob tags.
-        :rtype: Optional[Dict[str, str]]
+        :rtype: Dict[str, str]
         """
         version_id = get_version_id(self.version_id, kwargs)
         options = _get_blob_tags_options(version_id=version_id, snapshot=self.snapshot, **kwargs)
         try:
             _, tags = self._client.blob.get_tags(**options)
-            return parse_tags(tags)
+            return cast(Dict[str, str], parse_tags(tags))
         except HttpResponseError as error:
             process_storage_error(error)
 

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client_helpers.py

@@ -757,7 +757,7 @@ def _stage_block_from_url_options(
     options.update(kwargs)
     return options
 
-def _get_block_list_result(blocks: BlockList) -> Tuple[List[Optional[BlobBlock]], List[Optional[BlobBlock]]]:
+def _get_block_list_result(blocks: BlockList) -> Tuple[List[BlobBlock], List[BlobBlock]]:
     committed = []
     uncommitted = []
     if blocks.committed_blocks:

sdk/storage/azure-storage-blob/azure/storage/blob/_models.py

@@ -775,13 +775,13 @@ class BlobBlock(DictMixin):
     """Block id."""
     state: BlockState
     """Block state."""
-    size: Optional[int]
+    size: int
     """Block size."""
 
     def __init__(self, block_id: str, state: BlockState = BlockState.LATEST) -> None:
         self.id = block_id
         self.state = state
-        self.size = None
+        self.size = None  # type: ignore [assignment]
 
     @classmethod
     def _from_generated(cls, generated):

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.py

@@ -1942,7 +1942,7 @@ async def stage_block_from_url(
     async def get_block_list(
         self, block_list_type: str = "committed",
         **kwargs: Any
-    ) -> Tuple[List[Optional[BlobBlock]], List[Optional[BlobBlock]]]:
+    ) -> Tuple[List[BlobBlock], List[BlobBlock]]:
         """The Get Block List operation retrieves the list of blocks that have
         been uploaded as part of a block blob.
 
@@ -1967,7 +1967,7 @@ async def get_block_list(
             see `here <https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/storage/azure-storage-blob
             #other-client--per-operation-configuration>`__.
         :returns: A tuple of two lists - committed and uncommitted blocks
-        :rtype: tuple(list(~azure.storage.blob.BlobBlock), list(~azure.storage.blob.BlobBlock))
+        :rtype: Tuple[List[BlobBlock], List[BlobBlock]]
         """
         access_conditions = get_access_conditions(kwargs.pop('lease', None))
         mod_conditions = get_modify_conditions(kwargs)
@@ -2187,7 +2187,7 @@ async def set_blob_tags(self, tags: Optional[Dict[str, str]] = None, **kwargs: A
             process_storage_error(error)
 
     @distributed_trace_async
-    async def get_blob_tags(self, **kwargs: Any) -> Optional[Dict[str, str]]:
+    async def get_blob_tags(self, **kwargs: Any) -> Dict[str, str]:
         """The Get Tags operation enables users to get tags on a blob or specific blob version, but not snapshot.
 
         .. versionadded:: 12.4.0
@@ -2216,7 +2216,7 @@ async def get_blob_tags(self, **kwargs: Any) -> Optional[Dict[str, str]]:
         options = _get_blob_tags_options(version_id=version_id, snapshot=self.snapshot, **kwargs)
         try:
             _, tags = await self._client.blob.get_tags(**options)
-            return parse_tags(tags)  # pylint: disable=protected-access
+            return cast(Dict[str, str], parse_tags(tags))  # pylint: disable=protected-access
         except HttpResponseError as error:
             process_storage_error(error)