Skip to content

Microsoft.Azure.SignalR.Protocol MessagePack V2 breaking change #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcodemagalhaes opened this issue Jan 16, 2020 · 4 comments
Closed

Comments

@marcodemagalhaes
Copy link

Hi

When I upgraded messagepack to v2 the Microsoft.Azure.SignalR.Protocols package started to get error because it implements v1

There are plans to migrate to messagepack v2?

Thanks!

@vicancy
Copy link
Member

vicancy commented Jan 17, 2020

As dotnet/aspnetcore#18133 (comment), we will follow the same practice to build MessagePack from source to prevent such issues in the future.

@tebeco
Copy link
Contributor

tebeco commented Jan 17, 2020

hello @vicancy

Can you enlighten me about the comment you linked.
Are you planning to :

  • Use MessagePack as a SubModule + build from source
  • Update MessagePack as a Major / Breaking Change version ?

EDIT : see #803

@tebeco
Copy link
Contributor

tebeco commented Feb 5, 2020

@marcodemagalhaes
I'm a bit ahead of schedule as it is not "reviewed / merged / released"
But to be clear, once the PR #803 is released
As it look for now, it only "removes" the Transitive dependency from Azure SignalR SDK on MessagePack.
This mean that if you ever use a SignalR Hub + MessagePackHubProtocol, you will be hit by dotnet/aspnetcore#18692
dotnet/aspnetcore#18692 (comment)

So depending on your use of SignalR it self, and the protocol you are using, you might be stuck until AspNetCore 5.x.

If you cannot wait until then, and can add complexity to your project, you might be able to fork the actual implementation of the MessagePackHubProtocol that has been merged in dotnet/aspnetcore on master branch
Please check that this is not in violation of any LICENSE and then update your LICENSE/3rPartNotice... to point to the dotnet/aspnetcore one ... i think ... please ask someone more familiar than me on that

@vicancy
Copy link
Member

vicancy commented Feb 20, 2020

With generous help offered by @tebeco, v1.4.0 removes the dependency.

@vicancy vicancy closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants