fix(sdk-coin-sol): cannot blind sing enablemenet sol tokens

TICKET: WP-5744

Author: mtexeira-simtlix

modules/sdk-coin-sol/src/sol.ts

@@ -6,6 +6,7 @@ import BigNumber from 'bignumber.js';
 import * as base58 from 'bs58';
 
 import {
+  AuditDecryptedKeyParams,
   BaseBroadcastTransactionOptions,
   BaseBroadcastTransactionResult,
   BaseCoin,
@@ -27,9 +28,13 @@ import {
   MPCTx,
   MPCTxs,
   MPCUnsignedTx,
+  MultisigType,
+  multisigTypes,
   OvcInput,
   OvcOutput,
   ParsedTransaction,
+  PopulatedIntent,
+  PrebuildTransactionWithIntentOptions,
   PresignTransactionOptions,
   PublicKey,
   RecoveryTxRequest,
@@ -40,14 +45,10 @@ import {
   TransactionRecipient,
   VerifyAddressOptions,
   VerifyTransactionOptions,
-  MultisigType,
-  multisigTypes,
-  AuditDecryptedKeyParams,
-  PopulatedIntent,
-  PrebuildTransactionWithIntentOptions,
 } from '@bitgo/sdk-core';
 import { auditEddsaPrivateKey, getDerivationPath } from '@bitgo/sdk-lib-mpc';
 import { BaseNetwork, CoinFamily, coins, BaseCoin as StaticsBaseCoin } from '@bitgo/statics';
+import { TOKEN_2022_PROGRAM_ID, TOKEN_PROGRAM_ID } from '@solana/spl-token';
 import * as _ from 'lodash';
 import * as request from 'superagent';
 import { KeyPair as SolKeyPair, Transaction, TransactionBuilder, TransactionBuilderFactory } from './lib';
@@ -60,7 +61,6 @@ import {
   isValidPublicKey,
   validateRawTransaction,
 } from './lib/utils';
-import { TOKEN_2022_PROGRAM_ID, TOKEN_PROGRAM_ID } from '@solana/spl-token';
 
 export const DEFAULT_SCAN_FACTOR = 20; // default number of receive addresses to scan for funds
 
@@ -173,6 +173,8 @@ export interface SolConsolidationRecoveryOptions extends MPCConsolidationRecover
 }
 
 const HEX_REGEX = /^[0-9a-fA-F]+$/;
+const BLIND_SIGNING_TX_TYPES_TO_CHECK = { enabletoken: 'AssociatedTokenAccountInitialization' };
+const BLIND_SIGNING_TX_TYPES_WITH_EMPTY_OUTPUTS = ['enabletoken'];
 
 export class Sol extends BaseCoin {
   protected readonly _staticsCoin: Readonly<StaticsBaseCoin>;
@@ -233,6 +235,32 @@ export class Sol extends BaseCoin {
     return Math.pow(10, this._staticsCoin.decimalPlaces);
   }
 
+  verifyTxType(expectedTypeFromUserParams: string | undefined, actualTypeFromDecoded: string | undefined): void {
+    // do nothing, let the tx fail way down as always
+    if (expectedTypeFromUserParams === undefined || actualTypeFromDecoded === undefined) return;
+
+    // ex: user param comes with 'enabletoken' included in BLIND SIGNING -> if fails later in the IF check
+    // ex: user param comes with 'transfer' non included in BLIND SIGNING-> correctPrebuildTxType goes undefined and IF later goes false so it pass
+    // check the unit tests for this.
+    const correctPrebuildTxType = BLIND_SIGNING_TX_TYPES_TO_CHECK[expectedTypeFromUserParams];
+
+    if (correctPrebuildTxType && correctPrebuildTxType !== actualTypeFromDecoded) {
+      throw new Error(
+        `Tx type "${actualTypeFromDecoded}" does not match expected txParams type "${expectedTypeFromUserParams}"`
+      );
+    }
+  }
+
+  verifyNoOutputs(expectedTypeFromUserParams: string | undefined, decodedTxHex: TransactionExplanation): void {
+    if (
+      expectedTypeFromUserParams &&
+      BLIND_SIGNING_TX_TYPES_WITH_EMPTY_OUTPUTS.includes(expectedTypeFromUserParams) &&
+      decodedTxHex.outputs?.length > 0
+    ) {
+      throw new Error(`Tx outputs were found when none were expected for sol enablement tokens`);
+    }
+  }
+
   async verifyTransaction(params: SolVerifyTransactionOptions): Promise<boolean> {
     // asset name to transfer amount map
     const totalAmount: Record<string, BigNumber> = {};
@@ -261,6 +289,9 @@ export class Sol extends BaseCoin {
     transaction.fromRawTransaction(rawTxBase64);
     const explainedTx = transaction.explainTransaction();
 
+    this.verifyNoOutputs(txParams.type, explainedTx);
+    this.verifyTxType(txParams.type, explainedTx.type);
+
     // users do not input recipients for consolidation requests as they are generated by the server
     if (txParams.recipients !== undefined) {
       const filteredRecipients = txParams.recipients?.map((recipient) =>