fix(bitgo): use import = and type to resolve errors

TICKET: WP-5182

Author: mhahn2003

modules/bitgo/package.json

@@ -26,7 +26,7 @@
     "webpack-dev": "cross-env NODE_ENV=development webpack",
     "webpack-prod": "NODE_OPTIONS=--max-old-space-size=4096 cross-env NODE_ENV=production webpack",
     "test": "npm run coverage",
-    "unit-test": "mocha 'dist/test/v2/unit/**/*.js' 'dist/test/unit/**/*.js'",
+    "unit-test": "mocha 'test/v2/unit/**/*.ts' 'test/unit/**/*.ts'",
     "coverage": "nyc -- npm run unit-test",
     "integration-test": "nyc -- mocha \"test/v2/integration/**/*.ts\"",
     "browser-test": "karma start karma.conf.js",

modules/bitgo/test/unit/bip32path.ts

@@ -2,7 +2,7 @@
  * @prettier
  */
 import 'should';
-import { bip32, BIP32Interface } from '@bitgo/utxo-lib';
+import { bip32, type BIP32Interface } from '@bitgo/utxo-lib';
 import { sanitizeLegacyPath, bitcoin } from '@bitgo/sdk-core';
 import { getSeed } from '@bitgo/sdk-test';
 const { HDNode, hdPath } = bitcoin;

modules/bitgo/test/unit/decryptKeychain.ts

@@ -1,5 +1,5 @@
 import 'should';
-import { decryptKeychainPrivateKey, OptionalKeychainEncryptedKey } from '@bitgo/sdk-core';
+import { decryptKeychainPrivateKey, type OptionalKeychainEncryptedKey } from '@bitgo/sdk-core';
 import { BitGoAPI } from '@bitgo/sdk-api';
 
 describe('decryptKeychainPrivateKey', () => {

modules/bitgo/test/v2/unit/accountConsolidations.ts

@@ -12,7 +12,7 @@ import { common, Wallet } from '@bitgo/sdk-core';
 
 import { TestBitGo } from '@bitgo/sdk-test';
 import { BitGo } from '../../../src/bitgo';
-const algoFixtures = require('../../../../../sdk-coin-algo/test/fixtures/algo');
+const algoFixtures = require('../../../../sdk-coin-algo/test/fixtures/algo');
 
 nock.disableNetConnect();
 

modules/bitgo/test/v2/unit/coins/utxo/recovery/mock.ts

@@ -2,8 +2,8 @@
  * @prettier
  */
 import { bitgo } from '@bitgo/utxo-lib';
-import { AddressInfo, TransactionIO } from '@bitgo/blockapis';
-import { AbstractUtxoCoin, RecoveryProvider } from '@bitgo/abstract-utxo';
+import type { AddressInfo, TransactionIO } from '@bitgo/blockapis';
+import type { AbstractUtxoCoin, RecoveryProvider } from '@bitgo/abstract-utxo';
 import * as utxolib from '@bitgo/utxo-lib';
 import { Bch } from '@bitgo/sdk-coin-bch';
 import { Bsv } from '@bitgo/sdk-coin-bsv';
@@ -52,13 +52,15 @@ export class MockRecoveryProvider implements RecoveryProvider {
   }
 }
 export class MockCrossChainRecoveryProvider<TNumber extends number | bigint> implements RecoveryProvider {
+  public coin: AbstractUtxoCoin;
+  public unspents: Unspent<TNumber>[];
+  public tx: utxolib.bitgo.UtxoTransaction<TNumber>;
   private addressVersion: 'cashaddr' | 'base58';
   private addressFormat: utxolib.addressFormat.AddressFormat;
-  constructor(
-    public coin: AbstractUtxoCoin,
-    public unspents: Unspent<TNumber>[],
-    public tx: utxolib.bitgo.UtxoTransaction<TNumber>
-  ) {
+  constructor(coin: AbstractUtxoCoin, unspents: Unspent<TNumber>[], tx: utxolib.bitgo.UtxoTransaction<TNumber>) {
+    this.coin = coin;
+    this.unspents = unspents;
+    this.tx = tx;
     // this is how blockchair will return the data, as a cashaddr for BCH like coins
     // BSV supports cashaddr, but at the time of writing the SDK does not support cashaddr for bsv
     this.addressFormat = this.coin instanceof Bch && !(this.coin instanceof Bsv) ? 'cashaddr' : 'default';

modules/bitgo/test/v2/unit/coins/utxo/util/keychains.ts

@@ -1,10 +1,10 @@
 /**
  * @prettier
  */
-import { Triple } from '@bitgo/sdk-core';
+import type { Triple } from '@bitgo/sdk-core';
 import { encrypt } from '@bitgo/sdk-api';
 import { getSeed } from '@bitgo/sdk-test';
-import { bip32, BIP32Interface, bitgo } from '@bitgo/utxo-lib';
+import { bip32, type BIP32Interface, bitgo } from '@bitgo/utxo-lib';
 
 type RootWalletKeys = bitgo.RootWalletKeys;
 

modules/bitgo/test/v2/unit/errors.ts

@@ -1,10 +1,11 @@
 import 'should';
-const assert = require('assert');
+import assert from 'assert';
 import { BitGoJsError, NodeEnvironmentError } from '@bitgo/sdk-core';
 
 describe('Error handling', () => {
   it('should capture stack trace', function namedFunc() {
     const { stack } = new BitGoJsError();
+    assert(stack);
     assert.match(stack, /BitGoJsError/);
     assert.match(stack, /at Context\.namedFunc/);
     new NodeEnvironmentError().stack!.should.match(/NodeEnvironmentError:/);

modules/bitgo/test/v2/unit/internal/opengpgUtils.ts

@@ -7,7 +7,7 @@ import { openpgpUtils } from '@bitgo/sdk-core';
 import { ecc as secp256k1 } from '@bitgo/utxo-lib';
 import * as sinon from 'sinon';
 
-const sodium = require('libsodium-wrappers-sumo');
+import sodium from 'libsodium-wrappers-sumo';
 
 describe('OpenGPG Utils Tests', function () {
   let senderKey: { publicKey: string; privateKey: string };

modules/bitgo/test/v2/unit/internal/tssUtils/common.ts

@@ -1,4 +1,4 @@
-import { ExchangeCommitmentResponse, RequestType, SignatureShareRecord } from '@bitgo/sdk-core';
+import { type ExchangeCommitmentResponse, RequestType, type SignatureShareRecord } from '@bitgo/sdk-core';
 import nock from 'nock';
 import * as _ from 'lodash';
 

modules/bitgo/test/v2/unit/mmi.ts

@@ -4,7 +4,7 @@ import { BitGo } from '../../../src/bitgo';
 import nock from 'nock';
 import { bip32 } from '@bitgo/utxo-lib';
 import { common, TransactionType } from '@bitgo/sdk-core';
-import { AvaxC as AvaxCAccountLib, getBuilder } from '@bitgo/account-lib';
+import { AvaxC as AvaxCAccountLib, getBuilder } from '../../../../account-lib';
 
 nock.enableNetConnect();