Skip to content

Commit 23909d8

Browse files
Christy ChenCommit Bot
Christy Chen
authored and
Commit Bot
committed
[Loc] Presubmit performance improvement
The current Loc presubmit are doing two checks: check_localizable_resources and check_localizability (Details of what they are checking: https://docs.google.com/document/d/1L6TkT2-42MMQ72ZSBMFwUaq7M6mDgA2X0x8oHHKaV_U/edit#heading=h.w1no7qaa0mi0) This CL merge two checks into one single check. check_localizability are modified into a utils file, and check_localizable_resources will also run those localizability checks when the files are visited. By doing this, we avoid the extra call to node during presubmit, and all files and nodes will only be visited once. Also adding these fixes https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2370103 Fix: - Pass the fullpath for comparison.(itemPath) - Normalize comparison between paths - using native fs.promises instead of promisify (nodejs/node#26581) Bug: 1116989 Change-Id: I054040d83a65b5f798a21c040096422e287bc799 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2381320 Reviewed-by: Vidal Diazleal <[email protected]> Reviewed-by: Tim van der Lippe <[email protected]> Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Christy Chen <[email protected]>
1 parent bef95be commit 23909d8

File tree

7 files changed

+292
-409
lines changed

7 files changed

+292
-409
lines changed

scripts/devtools_paths.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@ def check_localizable_resources_path():
6666
return path.join(devtools_root_path(), 'scripts', 'localization', 'check_localizable_resources.js')
6767

6868

69-
def check_localized_strings_path():
70-
return path.join(devtools_root_path(), 'scripts', 'localization', 'check_localizability.js')
71-
72-
7369
def karma_path():
7470
return path.join(node_modules_path(), 'karma', 'bin', 'karma')
7571

scripts/localization/check_localizability.js

Lines changed: 0 additions & 348 deletions
This file was deleted.

0 commit comments

Comments
 (0)