Skip to content

Please cherry-pick valgrind $ORIGIN patch from upstream #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geofft opened this issue Feb 6, 2025 · 5 comments
Closed

Please cherry-pick valgrind $ORIGIN patch from upstream #1

geofft opened this issue Feb 6, 2025 · 5 comments
Assignees

Comments

@geofft
Copy link

geofft commented Feb 6, 2025

Hi! Valgrind upstream just recently fixed bug 396415 "Valgrind is not looking up $ORIGIN rpath of shebang programs" with commit 1fefba79021779d840bbf8cebc43e40c74b40f31. This bug causes the Python installations used by uv to not work properly under CodSpeed. Specifically, if you run something like codspeed run pytest, pytest is a script whose shebang line references the Python installation, and valgrind does not run the Python interpreter properly.

Valgrind seems to release once or twice a year at most; can you please cherry-pick this patch onto your fork and include it in a CodSpeed release so uv users can get unblocked before then?

A simple reproducer is to do something like uv venv; . .venv/bin/activate; uv pip install pytest; codspeed run pytest, or something like this in GitHub Actions (see this sample run):

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: astral-sh/setup-uv@v5
with:
python-version: 3.13
- run: uv pip install pytest
- uses: CodSpeedHQ/action@v3
with:
run: pytest
@art049
Copy link
Member

art049 commented Feb 7, 2025

Hello, thanks for mentioning this. Will do a release ASAP and use it with the runner.

@art049 art049 self-assigned this Feb 7, 2025
@art049
Copy link
Member

art049 commented Feb 12, 2025

Done. Will release this with the next runner release. Thanks for notifying us about this.

@art049 art049 closed this as completed Feb 12, 2025
@geofft
Copy link
Author

geofft commented Feb 26, 2025

Hi, just checking in case I'm missing something—this was in runner 3.4.0, right? I'm still seeing the failure here:
https://github.com/geofft/actions-test-202112/actions/runs/13554709488/job/37886346486
https://github.com/geofft/actions-test-202112/actions/runs/13554709488/workflow
Is there a way to confirm the patched valgrind is in use?

Copy link
Member

art049 commented Feb 28, 2025

Hi, yes the new valgrind version is in use starting from 3.4.0.

We got uv working with Github Action on this version, and added an example in our docs.

The only difference I see is you used setup-uv to install python as well while we used setup-python. I know there might be some differences since the builds are not the same.

Please let me know if that fixes the issue so I can add it to our documentation 🙂

@nathanjmcdougall
Copy link

For what it's worth, I'm also getting this failure on v3.4.0.

From my perspective, the primary motivation for this change is to enable the use of setup-uv instead of setup-python, to simplify config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants