-
Notifications
You must be signed in to change notification settings - Fork 1
Please cherry-pick valgrind $ORIGIN patch from upstream #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, thanks for mentioning this. Will do a release ASAP and use it with the runner. |
Done. Will release this with the next runner release. Thanks for notifying us about this. |
Hi, just checking in case I'm missing something—this was in runner 3.4.0, right? I'm still seeing the failure here: |
Hi, yes the new valgrind version is in use starting from 3.4.0. We got uv working with Github Action on this version, and added an example in our docs. The only difference I see is you used Please let me know if that fixes the issue so I can add it to our documentation 🙂 |
For what it's worth, I'm also getting this failure on v3.4.0. From my perspective, the primary motivation for this change is to enable the use of |
Uh oh!
There was an error while loading. Please reload this page.
Hi! Valgrind upstream just recently fixed bug 396415 "Valgrind is not looking up $ORIGIN rpath of shebang programs" with commit 1fefba79021779d840bbf8cebc43e40c74b40f31. This bug causes the Python installations used by
uv
to not work properly under CodSpeed. Specifically, if you run something likecodspeed run pytest
,pytest
is a script whose shebang line references the Python installation, and valgrind does not run the Python interpreter properly.Valgrind seems to release once or twice a year at most; can you please cherry-pick this patch onto your fork and include it in a CodSpeed release so
uv
users can get unblocked before then?A simple reproducer is to do something like
uv venv; . .venv/bin/activate; uv pip install pytest; codspeed run pytest
, or something like this in GitHub Actions (see this sample run):The text was updated successfully, but these errors were encountered: