From 6d68bc7446beea054dbb98d979acf53fda96a42c Mon Sep 17 00:00:00 2001 From: mizix Date: Wed, 30 Apr 2014 17:09:40 +0900 Subject: [PATCH] Update TagRepository.php I changed 1. remove left join i think not need 'tricks' table. so I deleted remove leftJoin tricks. 2. select count key select count key 'tricks.id' => 'tag_trick.tag_id' What do you think? --- app/Tricks/Repositories/Eloquent/TagRepository.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/Tricks/Repositories/Eloquent/TagRepository.php b/app/Tricks/Repositories/Eloquent/TagRepository.php index 6db8beb..0306e30 100644 --- a/app/Tricks/Repositories/Eloquent/TagRepository.php +++ b/app/Tricks/Repositories/Eloquent/TagRepository.php @@ -70,13 +70,12 @@ public function findAllWithTrickCount() { return $this->model ->leftJoin('tag_trick', 'tags.id', '=', 'tag_trick.tag_id') - ->leftJoin('tricks', 'tricks.id', '=', 'tag_trick.trick_id') ->groupBy('tags.slug') ->orderBy('trick_count', 'desc') ->get([ 'tags.name', 'tags.slug', - DB::raw('COUNT(tricks.id) as trick_count') + DB::raw('COUNT(tag_trick.tag_id) as trick_count') ]); }