Skip to content

Make improvements to elm examples (with datashader, bokeh-geo, etc) #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
PeterDSteinberg opened this issue Jun 14, 2017 · 6 comments
Closed
3 tasks done
Assignees

Comments

@PeterDSteinberg
Copy link
Contributor

PeterDSteinberg commented Jun 14, 2017

It would be nice to make use of the example datasets of datashader and its system for downloading those. Some examples with elm could benefit from using the U.S. census data and other data sets. We may also be able to leverage bokeh-geo, either by replacing it with an example, or using it in conjunction with elm.

TODO:

  • Document how to get the datashader example data and its relevance to elm - both the relevance of datashader itself and the example data
  • Documentation should show how to download that data in a way that the notebooks in ./examples of elm can find the datashader example data at a typical place or check several places or use an env variable to find it
  • Document / show off bokeh-geo examples in a notebook - this could go into either datashader or elm.
@gbrener
Copy link
Contributor

gbrener commented Jun 14, 2017

Ok, I assume that we'll want to add the documentation to https://github.com/ContinuumIO/elm/blob/master/docs/source/examples.rst? Marking as "ready" to work on.

@PeterDSteinberg
Copy link
Contributor Author

examples.rst sounds like a good place for the new docs, @gbrener .

@PeterDSteinberg
Copy link
Contributor Author

Related to this issue, I need to finish and merge #166 when datashader regridding /resampling options are merged. That notebook in #166 was held up by some unclarity / deficiencies I found in the scoring of supervised models.

@gbrener gbrener changed the title Make use of datashader example data for elm examples Improve elm examples (with datashader, bokeh-geo, etc) Jun 15, 2017
@gbrener gbrener changed the title Improve elm examples (with datashader, bokeh-geo, etc) Make improvements to elm examples (with datashader, bokeh-geo, etc) Jun 15, 2017
@gbrener
Copy link
Contributor

gbrener commented Jun 15, 2017

@PeterDSteinberg , PR holoviz/datashader#375 is now merged, however after a conversation with @jbednar we may want to be careful with the cvs.raster() API with respect to the upsample_method and downsample_method keyword arguments. These are very likely to change within the next day or two, including the philosophy of how these parameters are specified (the alternative will likely involve a settings-style object based on the param library, but it hasn't been decided yet).

@gbrener
Copy link
Contributor

gbrener commented Jun 28, 2017

@PeterDSteinberg I marked the first two items as "done" now that we have a README and script in elm/examples directory with PR #166 .

@gbrener
Copy link
Contributor

gbrener commented Jul 5, 2017

Closing issue, since all 3 boxes are checked.

@gbrener gbrener closed this as completed Jul 5, 2017
@gbrener gbrener removed the ready label Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants