update comments

Author: benjaminjb

internal/controller/postgrescluster/postgres.go

@@ -561,8 +561,6 @@ func (r *Reconciler) reconcilePostgresDataVolume(
 	return pvc, err
 }
 
-// TODO think about multiple tablespace volumes
-
 // +kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=create;patch
 
 // reconcileTablespaceVolumes writes the PersistentVolumeClaims for instance's

internal/postgres/config.go

@@ -205,15 +205,14 @@ func startupCommand(
 	version := fmt.Sprint(cluster.Spec.PostgresVersion)
 	walDir := WALDirectory(cluster, instance)
 
-	// If the user requests tablespaces, we want to create and chmod the directories
+	// If the user requests tablespaces, we want to make sure the directories exist with the
+	// correct owner and permissions.
 	tablespaceCmd := ""
 	if util.DefaultMutableFeatureGate.Enabled(util.TablespaceVolumes) && instance.TablespaceVolumes != nil {
 		// This command checks if a dir exists and if not, creates it;
 		// if the dir does exist, then we `recreate` it to make sure the owner is correct;
 		// but if the dir exists with the wrong owner and is not writeable, we error.
 		// This is the same behavior we use for the main PGDATA directory.
-		// The path for tablespaces volumes is /tablespaces/NAME/data
-		// -- the `data` path is added so that we can arrange the permissions.
 		checkInstallRecreateCmd := strings.Join([]string{
 			`if [[ ! -e "${tablespace_dir}" || -O "${tablespace_dir}" ]]; then`,
 			`install --directory --mode=0700 "${tablespace_dir}"`,
@@ -224,6 +223,8 @@ func startupCommand(
 		}, "\n")
 
 		for _, tablespace := range instance.TablespaceVolumes {
+			// The path for tablespaces volumes is /tablespaces/NAME/data
+			// -- the `data` path is added so that we can arrange the permissions.
 			tablespaceCmd = tablespaceCmd + "\ntablespace_dir=/tablespaces/" + tablespace.Name + "/data" + "\n" +
 				checkInstallRecreateCmd
 		}