Merge pull request #5 from DBC-BootUp/rspec

jritten · web-flow · commit a7fa4eb7eef0 · 2017-12-04T14:36:46.000-08:00
Rspec for company model associations
diff --git a/Gemfile b/Gemfile
@@ -40,6 +40,7 @@ group :development, :test do
   gem "factory_bot_rails", "~> 4.0"
   gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master'
   gem 'dotenv-rails'
+  gem 'shoulda-matchers', '~> 3.1'
 end
 
 group :development do
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -154,6 +154,8 @@ GEM
       sprockets (>= 2.8, < 4.0)
       sprockets-rails (>= 2.0, < 4.0)
       tilt (>= 1.1, < 3)
+    shoulda-matchers (3.1.2)
+      activesupport (>= 4.0.0)
     spring (2.0.2)
       activesupport (>= 4.2)
     spring-watcher-listen (2.0.1)
@@ -198,6 +200,7 @@ DEPENDENCIES
   rails-controller-testing
   rspec-rails
   sass-rails (~> 5.0)
+  shoulda-matchers (~> 3.1)
   spring
   spring-watcher-listen (~> 2.0.0)
   tzinfo-data
diff --git a/app/controllers/companies_controller.rb b/app/controllers/companies_controller.rb
@@ -35,6 +35,6 @@ def destroy
 
   private
   def company_params
-    params.require(:company).permit(:name, :location, :website, :tech_field, :has_apprenticeship?)
+    params.require(:company).permit(:name, :location, :website, :tech_field, :has_apprenticeship)
   end
 end
diff --git a/app/controllers/interviews_controller.rb b/app/controllers/interviews_controller.rb
@@ -39,6 +39,6 @@ def destroy
 
   private
   def interview_params
-    params.require(:interview).permit(:job_title, :referred?, :received_offer?, :notes, :difficulty_rating, :experience_rating, :accepted_offer?, :phone_screen?, :phone_screen_details, :tech_screen?, :tech_screen_details, :take_home_challenge?, :take_home_challenge_details, :onsite?, :onsite_details, :whiteboarding?, :whiteboarding_details, :negotiation_details, :user_id, :company_id)
+    params.require(:interview).permit(:job_title, :referred, :received_offer, :notes, :difficulty_rating, :experience_rating, :accepted_offer, :phone_screen, :phone_screen_details, :tech_screen, :tech_screen_details, :take_home_challenge, :take_home_challenge_details, :onsite, :onsite_details, :whiteboarding, :whiteboarding_details, :negotiation_details, :user_id, :company_id)
   end
 end
diff --git a/db/migrate/20171204010457_create_companies.rb b/db/migrate/20171204010457_create_companies.rb
@@ -5,7 +5,7 @@ def change
       t.string :location
       t.string :website
       t.string :tech_field
-      t.boolean :has_apprenticeship?
+      t.boolean :has_apprenticeship
 
       t.timestamps
     end
diff --git a/db/migrate/20171204013338_create_interviews.rb b/db/migrate/20171204013338_create_interviews.rb
@@ -2,21 +2,21 @@ class CreateInterviews < ActiveRecord::Migration[5.1]
   def change
     create_table :interviews do |t|
       t.string :job_title
-      t.boolean :referred?
-      t.boolean :received_offer?
+      t.boolean :referred
+      t.boolean :received_offer
       t.text :notes
       t.integer :difficulty_rating
       t.integer :experience_rating
-      t.boolean :accepted_offer?
-      t.boolean :phone_screen?
+      t.boolean :accepted_offer
+      t.boolean :phone_screen
       t.text :phone_screen_details
-      t.boolean :tech_screen?
+      t.boolean :tech_screen
       t.text :tech_screen_details
-      t.boolean :take_home_challenge?
+      t.boolean :take_home_challenge
       t.text :take_home_challenge_details
-      t.boolean :onsite?
+      t.boolean :onsite
       t.text :onsite_details
-      t.boolean :whiteboarding?
+      t.boolean :whiteboarding
       t.text :whiteboarding_details
       t.text :negotiation_details
       t.references :user
diff --git a/db/schema.rb b/db/schema.rb
@@ -20,7 +20,7 @@
     t.string "location"
     t.string "website"
     t.string "tech_field"
-    t.boolean "has_apprenticeship?"
+    t.boolean "has_apprenticeship"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end
@@ -34,21 +34,21 @@
 
   create_table "interviews", force: :cascade do |t|
     t.string "job_title"
-    t.boolean "referred?"
-    t.boolean "received_offer?"
+    t.boolean "referred"
+    t.boolean "received_offer"
     t.text "notes"
     t.integer "difficulty_rating"
     t.integer "experience_rating"
-    t.boolean "accepted_offer?"
-    t.boolean "phone_screen?"
+    t.boolean "accepted_offer"
+    t.boolean "phone_screen"
     t.text "phone_screen_details"
-    t.boolean "tech_screen?"
+    t.boolean "tech_screen"
     t.text "tech_screen_details"
-    t.boolean "take_home_challenge?"
+    t.boolean "take_home_challenge"
     t.text "take_home_challenge_details"
-    t.boolean "onsite?"
+    t.boolean "onsite"
     t.text "onsite_details"
-    t.boolean "whiteboarding?"
+    t.boolean "whiteboarding"
     t.text "whiteboarding_details"
     t.text "negotiation_details"
     t.bigint "user_id"
diff --git a/package-lock.json b/package-lock.json
diff --git a/spec/controllers/companies_controller_spec.rb b/spec/controllers/companies_controller_spec.rb
@@ -9,9 +9,9 @@
     end
   end
 
-  describe "GET #create" do
+  describe "POST #create" do
     it "returns http success" do
-      get :create
+      post :create, params: {company: {name: 'Create', location: 'placeName', website: 'cnn.com', tech_field: 'edtech', has_apprenticeship: true}}
       expect(response).to have_http_status(:success)
     end
   end
diff --git a/spec/factories/companies.rb b/spec/factories/companies.rb
@@ -6,8 +6,8 @@
     location { "#{Faker::Address.city}, #{Faker::Address.state}" }
     website { Faker::Internet.url }
     tech_field { Faker::Company.catch_phrase }
-    has_apprenticeship? { [true, false].sample }
-    skills do 
+    has_apprenticeship { [true, false].sample }
+    skills do
       FactoryBot.create(:skill) until Skill.all.length > skill_count
       Skill.all.sample(skill_count)
     end
diff --git a/spec/factories/interviews.rb b/spec/factories/interviews.rb
@@ -3,27 +3,27 @@
     transient { skill_count 4 }
 
     job_title "MyString"
-    referred? { [true, false].sample }
-    received_offer? false
+    referred { [true, false].sample }
+    received_offer false
     notes "MyText"
     difficulty_rating { (1..3).to_a.sample }
     experience_rating { (1..3).to_a.sample }
-    accepted_offer? { [true, false].sample }
-    phone_screen? { [true, false].sample }
+    accepted_offer { [true, false].sample }
+    phone_screen { [true, false].sample }
     phone_screen_details { Faker::Hacker.say_something_smart }
-    tech_screen? { [true, false].sample  }
+    tech_screen { [true, false].sample  }
     tech_screen_details { Faker::Hacker.say_something_smart }
-    take_home_challenge? { [true, false].sample  }
+    take_home_challenge { [true, false].sample  }
     take_home_challenge_details { Faker::Hacker.say_something_smart }
-    onsite? { [true, false].sample  }
+    onsite { [true, false].sample  }
     onsite_details { Faker::Hacker.say_something_smart }
-    whiteboarding? { [true, false].sample  }
+    whiteboarding { [true, false].sample  }
     whiteboarding_details { Faker::Hacker.say_something_smart }
     negotiation_details { Faker::Hacker.say_something_smart }
 
     interviewee { User.all.sample || FactoryBot.create(:user) }
     company { Company.all.sample || FactoryBot.create(:company) }
-    skills do 
+    skills do
       FactoryBot.create(:skill) until Skill.all.length > skill_count
       Skill.all.sample(skill_count)
     end
diff --git a/spec/factories/users.rb b/spec/factories/users.rb
@@ -17,7 +17,7 @@
     current_company { Faker::Company.name }
     current_position { Faker::Company.profession }
     photo_url { Faker::Fillmurray.image }
-    skills do 
+    skills do
       FactoryBot.create(:skill) until Skill.all.length > skill_count
       Skill.all.sample(skill_count)
     end
diff --git a/spec/models/company_spec.rb b/spec/models/company_spec.rb
@@ -1,5 +1,60 @@
 require 'rails_helper'
 
-RSpec.describe Company, type: :model do
-  pending "add some examples to (or delete) #{__FILE__}"
+describe Company do
+  let(:company) { Company.create!(
+    name: "Paypal",
+    location: "Palo Alto",
+    website: "paypal.com",
+    tech_field: 'fin tech',
+    has_apprenticeship: 'false')
+  }
+  let(:interviewee) { User.create!(
+    name: "Bob Roberts",
+    year: "2015",
+    cohort: "Smelly Poodles",
+    location: "San Carlos")
+  }
+  let(:interview) { Interview.create!(
+    company: company,
+    interviewee: interviewee,
+    job_title: "Junior Engineer",
+    referred: "false",
+    received_offer: true,
+    notes: "good culture",
+    difficulty_rating: 3,
+    experience_rating: 2,
+    accepted_offer: true,
+    phone_screen: true,
+    phone_screen_details: "lasted 2 hours",
+    tech_screen: true,
+    tech_screen_details: "ruby and javascript",
+    take_home_challenge: true,
+    take_home_challenge_details: "took 8 hours to complete",
+    onsite: true,
+    onsite_details: "met with 7 people",
+    whiteboarding: false,
+    whiteboarding_details: "none",
+    negotiation_details: "counteroffer accepted")
+    }
+  let(:skill) { Skill.create!(
+    name: "javascript")
+  }
+  let(:user) { User.create!(
+    name: "Bob Roberts",
+    year: "2015",
+    cohort: "Smelly Poodles",
+    location: "San Carlos")
+  }
+
+
+  describe "associations" do
+    it "has many interviews" do
+      expect(company.interviews).to eq [interview]
+    end
+
+    it "has many interviewees" do
+        FactoryBot.create(:interview, {company: company, interviewee: interviewee})
+        expect(company.interviewees.first).to eq interviewee
+    end
+  end
 end
