Add [Main] section header to end of datadog.conf enable_trace_agent template conditional #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate conditional
|
Thanks for reporting and submitting a fix @bflad ! We'll review it shortly (today or tomorrow). |
olivielpeau
approved these changes
Mar 28, 2017
There was a problem hiding this comment.
LGTM, thanks @bflad!
I've double-checked that the ini parser used by the Agent merges duplicate sections nicely
olivielpeau
reviewed
Mar 28, 2017
templates/default/datadog.conf.erb
Outdated
| @@ -72,6 +72,8 @@ max_traces_per_second: <%= node['datadog']['max_traces_per_second'] %> | |||
| [trace.receiver] | |||
| receiver_port: <%= node['datadog']['receiver_port'] %> | |||
| connection_limit: <%= node['datadog']['connection_limit'] %> | |||
|
|
|||
| [Main] | |||
There was a problem hiding this comment.
Actually this works, but I think it would be more human-readable to have the whole Main section in one block.
Could you move the whole trace-agent-related part of the config at the end of the file so that the Main section is not split?
There was a problem hiding this comment.
I've pushed up that change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplest fix for #418.