Make sd_jmx_enable configurable #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathvik-dhanya
approved these changes
Sep 26, 2018
rogoman
approved these changes
Sep 27, 2018
Support configuring sd_jmx_enable via attributes, which allows us to create JMX checks using Docker labels (or other SD config backends). Signed-off-by: Chris Gianelloni <[email protected]>
wolf31o2
force-pushed
the
configure-sd-jmx-enable
branch
from
8f195ce to
786fcf6
Compare
|
Rebased against current master |
|
Thank you @wolf31o2 for your contribution 👍! I'm merging it to master and it will be part of release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support configuring sd_jmx_enable via attributes, which allows us to
create JMX checks using Docker labels (or other SD config backends).
Signed-off-by: Chris Gianelloni [email protected]