Skip to content

Commit cbc6f39

Browse files
committed
Change base tag latest to latest_base
1 parent d0f7f91 commit cbc6f39

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Dockerfile

-2
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,13 @@ ENV PATH=${JAVA_HOME}/bin:${PATH}
132132
FROM base AS variant
133133
ARG VARIANT_LOWER
134134
ARG VARIANT_UPPER
135-
ARG LATEST_VERSION
136135

137136
COPY --from=all-jdk /usr/lib/jvm/${VARIANT_LOWER} /usr/lib/jvm/${VARIANT_LOWER}
138137
ENV JAVA_${VARIANT_UPPER}_HOME=/usr/lib/jvm/${VARIANT_LOWER}
139138
ENV JAVA_${VARIANT_LOWER}_HOME=/usr/lib/jvm/${VARIANT_LOWER}
140139

141140
# Full image for debugging, contains all JDKs.
142141
FROM base AS full
143-
ARG LATEST_VERSION
144142

145143
COPY --from=all-jdk /usr/lib/jvm/7 /usr/lib/jvm/7
146144
COPY --from=all-jdk /usr/lib/jvm/zulu8 /usr/lib/jvm/zulu8

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Docker images for continuous integration jobs at [dd-trace-java](https://github.
77
Pre-built images are available in [GitHub Container Registry](https://github.com/DataDog/dd-trace-java-docker-build/pkgs/container/dd-trace-java-docker-build).
88

99
Image variants are available on a per JDK basis:
10-
- The `base` variant, and its aliases `8`, `11`, `17`, `21`, and `latest`, contains the base Eclipse Temurin JDK 8, 11, 17, 21, and latest JDK versions,
10+
- The `base` variant, and its aliases `8`, `11`, `17`, `21`, and `latest_base`, contains the base Eclipse Temurin JDK 8, 11, 17, 21, and latest JDK versions,
1111
- The `zulu8`, `zulu11`, `oracle8`, `ibm8`, `semeru8`, `semeru11`, `semeru17`, `graalvm17` and `graalvm21` variants all contain the base JDKs in addition to their specific JDK from their name,
1212
- The `latest` variant contains the base JDKs and all the above specific JDKs.
1313

build

+7-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ set -eu
33

44
readonly IMAGE_NAME="ghcr.io/datadog/dd-trace-java-docker-build"
55

6-
readonly BASE_VARIANTS=(8 11 17 21 latest)
6+
readonly BASE_VARIANTS=(8 11 17 21 latest_base)
77

88
readonly VARIANTS=(
99
7
@@ -163,6 +163,10 @@ function do_inner_test() {
163163
"${!java_latest_home}/bin/java" -version
164164

165165
if [[ $variant != base && $variant != latest ]]; then
166+
if [[ $variant == "latest_base" ]]; then
167+
variant_lower="${LATEST_VERSION}"
168+
variant_upper="${LATEST_VERSION}"
169+
fi
166170
env_lower="JAVA_${variant_lower}_HOME"
167171
env_upper="JAVA_${variant_upper}_HOME"
168172
"${!env_lower}/bin/java" -version
@@ -171,10 +175,10 @@ function do_inner_test() {
171175
}
172176

173177
function do_describe() {
174-
local image
175178
compute_metadata
176179
compute_latest_version
177180
docker_build full "$(image_name latest)"
181+
local image
178182
image="$(image_name latest)"
179183
docker run \
180184
--user "$(id -u):$(id -g)" \
@@ -205,7 +209,7 @@ function do_inner_describe() {
205209
echo "## JDKs"
206210
echo
207211
for variant in "${BASE_VARIANTS[@]}" "${VARIANTS[@]}"; do
208-
if [[ $variant == "latest" ]]; then
212+
if [[ $variant == "latest_base" ]]; then
209213
variant_upper="${LATEST_VERSION}"
210214
else
211215
variant_upper="${variant^^}"

0 commit comments

Comments
 (0)