Create metric: appsec.waf.config_errors

Author: sezen-datadog

internal-api/src/main/java/datadog/trace/api/telemetry/WafMetricCollector.java

@@ -246,11 +246,11 @@ public void prepareMetrics() {
     }
 
     // WAF config errors
-    if (!rawMetricsQueue.offer(
-        new WafConfigError(
-            wafConfigErrorCounter.getAndSet(0),
-            WafMetricCollector.wafVersion,
-            WafMetricCollector.rulesVersion))) {}
+    int configErrors = wafConfigErrorCounter.getAndSet(0);
+    if (configErrors > 0
+        && !rawMetricsQueue.offer(
+            new WafConfigError(
+                configErrors, WafMetricCollector.wafVersion, WafMetricCollector.rulesVersion))) {}
   }
 
   public abstract static class WafMetric extends MetricCollector.Metric {

internal-api/src/test/groovy/datadog/trace/api/telemetry/WafMetricCollectorTest.groovy

@@ -27,12 +27,12 @@ class WafMetricCollectorTest extends DDSpecification {
     WafMetricCollector.get().wafRequestTriggered()
     WafMetricCollector.get().wafRequestBlocked()
     WafMetricCollector.get().wafRequestTimeout()
-    WafMetricCollector.get().wafConfigError()
     WafMetricCollector.get().raspRuleEval(RuleType.SQL_INJECTION)
     WafMetricCollector.get().raspRuleEval(RuleType.SQL_INJECTION)
     WafMetricCollector.get().raspRuleMatch(RuleType.SQL_INJECTION)
     WafMetricCollector.get().raspRuleEval(RuleType.SQL_INJECTION)
     WafMetricCollector.get().raspTimeout(RuleType.SQL_INJECTION)
+
     WafMetricCollector.get().prepareMetrics()
 
     then:
@@ -142,7 +142,7 @@ class WafMetricCollectorTest extends DDSpecification {
     def metrics = WafMetricCollector.get().drain()
 
 
-    def wafConfigError = (WafMetricCollector.RaspTimeout)metrics[0]
+    def wafConfigError = (WafMetricCollector.WafConfigError)metrics[0]
     wafConfigError.type == 'count'
     wafConfigError.value == 1
     wafConfigError.namespace == 'appsec'