review

Author: amarziali

internal-api/src/main/java/datadog/trace/api/ProcessTags.java

@@ -55,7 +55,7 @@ private static void fillJeeTags(SortedMap<String, String> tags) {
       fillWebsphereTags(tags);
     }
 
-    private static void insertSysPropIfPresent(
+    private static void insertTagFromSysPropIfPresent(
         Map<String, String> tags, String propKey, String tagKey) {
       String value = maybeGetSystemProperty(propKey);
       if (value != null) {
@@ -71,7 +71,7 @@ private static String maybeGetSystemProperty(String propKey) {
       return null;
     }
 
-    private static boolean insertEnvIfPresent(
+    private static boolean insertTagFromEnvIfPresent(
         Map<String, String> tags, String envKey, String tagKey) {
       try {
         String value = envGetter.apply(envKey);
@@ -128,16 +128,16 @@ private static void fillBaseTags(Map<String, String> tags) {
     private static boolean fillJbossTags(Map<String, String> tags) {
       if (insertLastPathSegmentIfPresent(
           tags, maybeGetSystemProperty("jboss.home.dir"), "jboss.home")) {
-        insertSysPropIfPresent(tags, "jboss.server.name", SERVER_NAME);
+        insertTagFromSysPropIfPresent(tags, "jboss.server.name", SERVER_NAME);
         tags.put("jboss.mode", hasSystemProperty("[Standalone]") ? "standalone" : "domain");
         return true;
       }
       return false;
     }
 
     private static boolean fillWebsphereTags(Map<String, String> tags) {
-      if (insertEnvIfPresent(tags, "WAS_CELL", CLUSTER_NAME)) {
-        insertEnvIfPresent(tags, "SERVER_NAME", SERVER_NAME);
+      if (insertTagFromEnvIfPresent(tags, "WAS_CELL", CLUSTER_NAME)) {
+        insertTagFromEnvIfPresent(tags, "SERVER_NAME", SERVER_NAME);
         return true;
       }
       return false;