Skip to content

Commit a55c4e7

Browse files
fix: pin importlib to 6.5.0 [backport 2.5] (#8196)
Backport c8d5e9f from #8075 to 2.5. ## Description - Pin importlib to 6.5.0 to avoid issue python/importlib_metadata#455 - Fix a potential unbound local error. Fixes #8068 ## Checklist - [X] Change(s) are motivated and described in the PR description. - [X] Testing strategy is described if automated tests are not included in the PR. - [X] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [X] Change is maintainable (easy to change, telemetry, documentation). - [X] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [X] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [X] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [x] This PR doesn't touch any of that. Co-authored-by: Juanjo Alvarez Martinez <[email protected]>
1 parent 77d5262 commit a55c4e7

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ dependencies = [
2828
"cattrs",
2929
"ddsketch>=2.0.1",
3030
"envier",
31-
"importlib_metadata; python_version<'3.8'",
31+
"importlib_metadata<=6.5.0; python_version<'3.8'",
3232
"opentelemetry-api>=1",
3333
"protobuf>=3",
3434
"setuptools; python_version>='3.12'",
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
fixes:
2+
- |
3+
Pin importlib_metadata to 6.5.0 to avoid its issue 455 (https://github.com/python/importlib_metadata/issues/455).

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,7 @@ def get_ddup_ext():
577577
"cattrs",
578578
"six>=1.12.0",
579579
"typing_extensions",
580-
"importlib_metadata; python_version<'3.8'",
580+
"importlib_metadata<=6.5.0; python_version<'3.8'",
581581
"xmltodict>=0.12",
582582
"envier",
583583
"opentelemetry-api>=1",

0 commit comments

Comments
 (0)