Skip to content

Commit a607bcd

Browse files
committed
removed user-agent header because it's very inconsistent
1 parent 439dc3a commit a607bcd

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

tests/contrib/flask/test_middleware.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ def test_success_200_ot(self):
388388
assert dd_span.meta.get(http.METHOD) == 'GET'
389389

390390
def test_http_request_header_tracing(self):
391-
config.flask.http.trace_headers(['User-Agent', 'Host', 'my-header'])
391+
config.flask.http.trace_headers(['Host', 'my-header'])
392392
self.app.get('/', headers={
393393
'my-header': 'my_value',
394394
})
@@ -399,13 +399,4 @@ def test_http_request_header_tracing(self):
399399
span = traces[0][0]
400400

401401
assert span.get_tag('http.request.headers.my-header') == 'my_value'
402-
user_agent = span.get_tag('http.request.headers.user-agent')
403-
host = span.get_tag('http.request.headers.host')
404-
405-
# ensure span contains either header
406-
assert (user_agent or host) is not None
407-
408-
if user_agent:
409-
assert user_agent == 'werkzeug/1.0.1'
410-
if host:
411-
assert host == 'localhost'
402+
assert span.get_tag('http.request.headers.host') == 'localhost'

0 commit comments

Comments
 (0)