-
Notifications
You must be signed in to change notification settings - Fork 0
Update VSCode Code Formatting #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The current documentation for VSCode for formatting Java points is outdated, is discussed here and can be confirmed by checking the last updated date on GitHub (as well as the differences noticed during our code review). It also looks like Google does not want to support configuration files, but instead push users wishing to follow the This .jar file is not immediately compatible with VSCode. It is a formatter/library which must be called through Java. There is a maven plugin that can assist with automating this process, but this requires a java version upgrade:
While I do not believe there would be an issue with upgrading java versions, doing so for the sole purpose of adding a new dependency does not sit quite right with me. I do not want to potentially introduce a dependency issue in the future (for a non-critical issue related to code formatting). The differences of formatting between IntelliJ and VSCode cannot be addressed (for now, maybe I've missed something) because there are no settings that can be adjusted to speak directly to the affected formatting issues discovered during code review.
The majority of these differences are related to tab settings and new lines, which do not affect the functionality of HashStore, and are more of an aesthetic issue. Any additional time spent trying to sync the two perfectly does not feel productive (or possible), so I am opting to stick with the current I am closing this issue, and will re-open if it is felt that we should allocate resources to ensure code formatting is 'perfect'. |
Uh oh!
There was an error while loading. Please reload this page.
When time-permitting, adjust the VSCode format settings to accurately reflect the expected formatting settings (reference IntelliJ's formatting as it is more accurate to the Google Style).
Examples:
);
and)
does not get placed on its own lines.The text was updated successfully, but these errors were encountered: