moved polar coord stuff into its own file

Author: keptsecret

include/nbl/builtin/hlsl/math/functions.hlsl

@@ -192,21 +192,6 @@ typename cpp_compat_intrinsics_impl::mul_helper<Lhs, Rhs>::return_t applyChainRu
     return hlsl::mul(dFdG, dGdR);
 }
 
-// takes in normalized vectors
-template<typename T>
-vector<T, 3> polarToCartesian(vector<T, 2> theta_phi)
-{
-    return vector<T, 3>(hlsl::cos(theta_phi.y) * hlsl::cos(theta_phi.x),
-                        hlsl::sin(theta_phi.y) * hlsl::cos(theta_phi.x),
-                        hlsl::sin(theta_phi.x));
-}
-
-template<typename T>
-vector<T, 2> cartesianToPolar(vector<T, 3> coords)
-{
-    return vector<T, 2>(hlsl::acos(clamp<float>(coords.z, -1, 1)), hlsl::atan2(coords.y, coords.x));
-}
-
 }
 }
 }

include/nbl/builtin/hlsl/math/polar.hlsl

@@ -0,0 +1,53 @@
+// Copyright (C) 2018-2025 - DevSH Graphics Programming Sp. z O.O.
+// This file is part of the "Nabla Engine".
+// For conditions of distribution and use, see copyright notice in nabla.h
+#ifndef _NBL_BUILTIN_HLSL_MATH_POLAR_INCLUDED_
+#define _NBL_BUILTIN_HLSL_MATH_POLAR_INCLUDED_
+
+#include "nbl/builtin/hlsl/cpp_compat.hlsl"
+#include "nbl/builtin/hlsl/numbers.hlsl"
+
+namespace nbl
+{
+namespace hlsl
+{
+namespace math
+{
+
+template<typename T>
+struct Polar
+{
+    using scalar_type = T;
+    using vector2_type = vector<T, 2>;
+    using vector3_type = vector<T, 3>;
+
+    // should be normalized
+    static Polar<T> createFromCartesian(const vector3_type coords)
+    {
+        Polar<T> retval;
+        retval.theta = hlsl::acos(coords.z);
+        retval.phi = hlsl::atan2(coords.y, coords.x);
+        return retval;
+    }
+
+    static vector3_type ToCartesian(const scalar_type theta, const scalar_type phi)
+    {
+        return vector<T, 3>(hlsl::cos(phi) * hlsl::cos(theta),
+            hlsl::sin(phi) * hlsl::cos(theta),
+            hlsl::sin(theta));
+    }
+
+    vector3_type getCartesian()
+    {
+        return ToCartesian(theta, phi);
+    }
+
+    scalar_type theta;
+    scalar_type phi;
+};
+
+}
+}
+}
+
+#endif

src/nbl/builtin/CMakeLists.txt

@@ -223,6 +223,7 @@ LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/linalg/transform.hlsl")
 LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/functions.hlsl")
 LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/geometry.hlsl")
 LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/intutil.hlsl")
+LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/polar.hlsl")
 LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/angle_adding.hlsl")
 LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/equations/quadratic.hlsl")
 LIST_BUILTIN_RESOURCE(NBL_RESOURCES_TO_EMBED "hlsl/math/equations/cubic.hlsl")