Skip to content

Commit 467c190

Browse files
committed
Improve media method
Avoid mutating the contents of the lists from the instance returned from `super()`, and instead use addition, [the recommended method of combining Media classes](https://docs.djangoproject.com/en/2.2/topics/forms/media/#combining-media-objects).
1 parent 9d6c172 commit 467c190

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

django_admin_row_actions/admin.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,11 @@ class AdminRowActionsMixin(object):
3030

3131
@property
3232
def media(self):
33-
css = super(AdminRowActionsMixin, self).media._css
34-
css['all'] = css.get('all', [])
35-
css['all'].extend(["css/jquery.dropdown.min.css"])
36-
37-
js = super(AdminRowActionsMixin, self).media._js
38-
js.extend(["js/jquery.dropdown.min.js",])
39-
40-
media = forms.Media(
41-
css=css, js=js
33+
return super(AdminRowActionsMixin, self).media + forms.Media(
34+
css={'all': ["css/jquery.dropdown.min.css"]},
35+
js=["js/jquery.dropdown.min.js"],
4236
)
4337

44-
return media
45-
4638
def get_list_display(self, request):
4739
self._request = request
4840
list_display = super(AdminRowActionsMixin, self).get_list_display(request)

0 commit comments

Comments
 (0)