Skip to content

Deploy ComiMD #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sylvainmetayer opened this issue Sep 20, 2018 · 5 comments
Closed

Deploy ComiMD #8

sylvainmetayer opened this issue Sep 20, 2018 · 5 comments
Labels
bug Something isn't working security

Comments

@sylvainmetayer
Copy link
Member

https://github.com/hackmdio/codimd
@sylvainmetayer sylvainmetayer added the enhancement New feature or request label Sep 20, 2018
@sylvainmetayer
Copy link
Member Author

sylvainmetayer commented Sep 21, 2018 •
edited
Loading

extension cannot be compiled with node V10.X

see nodejs/node#20528

@sylvainmetayer sylvainmetayer mentioned this issue Sep 25, 2018
Merged
@sylvainmetayer
Copy link
Member Author

As seen on #12 , we need to fix CodiMD

@sylvainmetayer sylvainmetayer added bug Something isn't working and removed enhancement New feature or request labels Sep 25, 2018
@sylvainmetayer
Copy link
Member Author

Big security issue : The codiMD container listen on all interfaces and is reacheable via HTTP !
We need to bind it to localhost, and proxy it via nginx (this doesn't seem to work)

@sylvainmetayer
Copy link
Member Author

This behaviour shouldn't be possible, as technically, port 3000 shouldn't be open. Maybe their is an issue with iptables ?

@sylvainmetayer sylvainmetayer mentioned this issue Oct 4, 2018
Closed
@sylvainmetayer
Copy link
Member Author

We won't deploy codimd for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sylvainmetayer