Skip to content
This repository was archived by the owner on Oct 10, 2024. It is now read-only.

Conversation

starlightknown
Copy link
Member

@starlightknown starlightknown commented Jun 13, 2021

Closes #559
IMG_20210613_232929

Copy link
Member

@Vyvy-vi Vyvy-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a screenshot of this running on the bot to the PR description?


export default {
preventWords: ['guyz', 'guyzz', 'bruh', 'duude', 'sir'],
preventWords: ['guyz', 'guyzz', 'bruh', 'duude', 'women', 'sir'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@starlightknown
Copy link
Member Author

Could you maybe add a screenshot to the issue of this running on the bot?

I did add a screenshot in the issue

@Vyvy-vi
Copy link
Member

Vyvy-vi commented Jun 13, 2021

Could you maybe add a screenshot to the issue of this running on the bot?

I did add a screenshot in the issue

oops, I meant the PR description

@starlightknown
Copy link
Member Author

starlightknown commented Jun 13, 2021

Ah sure, sorry
Done!

@Vyvy-vi
Copy link
Member

Vyvy-vi commented Jun 13, 2021

Oh, I meant a screenshot of the result after the fix, anyways the Pr is good :)

@Vyvy-vi Vyvy-vi merged commit 4fb02ae into EddieHubCommunity:main Jun 13, 2021
@starlightknown
Copy link
Member Author

Updated and... it's merged already 😅

@starlightknown starlightknown deleted the patch-3 branch June 13, 2021 18:01
@Vyvy-vi
Copy link
Member

Vyvy-vi commented Jun 13, 2021

Screenshot 2021-06-13 at 11 43 40 PM

(I meant this from the local bot instance)

@starlightknown
Copy link
Member Author

Will keep that in mind next time 😅
Silly question but this will only happen after the PR gets merged right? Like now. We could only get the ss of the bug and after the PR merging, we get the result

@Vyvy-vi
Copy link
Member

Vyvy-vi commented Jun 13, 2021

Essentially while making the PR, it's also good to run a local instance of the bot to see if it works as desired. (that's how you
can fetch the ss)
In this case, it wasn't completely necessary, but in other cases it can be great to go through a local instance, just to check if things work

@starlightknown
Copy link
Member Author

Got it, thanks a lot for a clear answer. Will do that for the future PRs if needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Bot flags women but not men

3 participants