Skip to content

Commit 682e89f

Browse files
rickhanloniiAndyPengc12
authored andcommitted
Turn on disableJavaScriptURLs for experimental (facebook#28462)
This is on everywhere, ready to turn on in the next major.
1 parent f0546bf commit 682e89f

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,6 @@ describe('ReactDOMServerIntegration - Untrusted URLs - disableJavaScriptURLs', (
195195

196196
function initModules() {
197197
jest.resetModules();
198-
const ReactFeatureFlags = require('shared/ReactFeatureFlags');
199-
ReactFeatureFlags.disableJavaScriptURLs = true;
200198

201199
React = require('react');
202200
ReactDOMClient = require('react-dom/client');

packages/shared/ReactFeatureFlags.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export const disableLegacyContext = false;
145145

146146
// Not ready to break experimental yet.
147147
// Disable javascript: URL strings in href for XSS protection.
148-
export const disableJavaScriptURLs = false;
148+
export const disableJavaScriptURLs = __NEXT_MAJOR__;
149149

150150
// Not ready to break experimental yet.
151151
// Modern <StrictMode /> behaviour aligns more with what components

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const enableFormActions = true; // Doesn't affect Test Renderer
2828
export const enableBinaryFlight = true;
2929
export const enableTaint = true;
3030
export const enablePostpone = false;
31-
export const disableJavaScriptURLs = false;
31+
export const disableJavaScriptURLs = true;
3232
export const disableCommentsAsDOMContainers = true;
3333
export const disableInputAttributeSyncing = false;
3434
export const disableIEWorkarounds = true;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const enableFormActions = true; // Doesn't affect Test Renderer
2828
export const enableBinaryFlight = true;
2929
export const enableTaint = true;
3030
export const enablePostpone = false;
31-
export const disableJavaScriptURLs = false;
31+
export const disableJavaScriptURLs = true;
3232
export const disableCommentsAsDOMContainers = true;
3333
export const disableInputAttributeSyncing = false;
3434
export const disableIEWorkarounds = true;

0 commit comments

Comments
 (0)