Skip to content

Commit 89d26c9

Browse files
noahlemenAndyPengc12
authored andcommitted
cleanup enableProfilerNestedUpdateScheduledHook feature flag (facebook#28509)
## Summary Looks like this was added years ago for instrumentation at meta that never ended up rolling out. Should be safe to clean up. ## How did you test this change? `yarn test`
1 parent 32c315c commit 89d26c9

10 files changed

+0
-504
lines changed

packages/react-reconciler/src/ReactFiberWorkLoop.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import {
3030
enableProfilerTimer,
3131
enableProfilerCommitHooks,
3232
enableProfilerNestedUpdatePhase,
33-
enableProfilerNestedUpdateScheduledHook,
3433
enableDebugTracing,
3534
enableSchedulingProfiler,
3635
disableSchedulerTimeoutInWorkLoop,
@@ -107,7 +106,6 @@ import {
107106
ForwardRef,
108107
MemoComponent,
109108
SimpleMemoComponent,
110-
Profiler,
111109
HostComponent,
112110
HostHoistable,
113111
HostSingleton,
@@ -581,10 +579,6 @@ let hasUncaughtError = false;
581579
let firstUncaughtError = null;
582580
let legacyErrorBoundariesThatAlreadyFailed: Set<mixed> | null = null;
583581

584-
// Only used when enableProfilerNestedUpdateScheduledHook is true;
585-
// to track which root is currently committing layout effects.
586-
let rootCommittingMutationOrLayoutEffects: FiberRoot | null = null;
587-
588582
let rootDoesHavePassiveEffects: boolean = false;
589583
let rootWithPendingPassiveEffects: FiberRoot | null = null;
590584
let pendingPassiveEffectsLanes: Lanes = NoLanes;
@@ -807,26 +801,6 @@ export function scheduleUpdateOnFiber(
807801

808802
warnIfUpdatesNotWrappedWithActDEV(fiber);
809803

810-
if (enableProfilerTimer && enableProfilerNestedUpdateScheduledHook) {
811-
if (
812-
(executionContext & CommitContext) !== NoContext &&
813-
root === rootCommittingMutationOrLayoutEffects
814-
) {
815-
if (fiber.mode & ProfileMode) {
816-
let current: null | Fiber = fiber;
817-
while (current !== null) {
818-
if (current.tag === Profiler) {
819-
const {id, onNestedUpdateScheduled} = current.memoizedProps;
820-
if (typeof onNestedUpdateScheduled === 'function') {
821-
onNestedUpdateScheduled(id);
822-
}
823-
}
824-
current = current.return;
825-
}
826-
}
827-
}
828-
}
829-
830804
if (enableTransitionTracing) {
831805
const transition = ReactCurrentBatchConfig.transition;
832806
if (transition !== null && transition.name != null) {
@@ -2938,12 +2912,6 @@ function commitRootImpl(
29382912
recordCommitTime();
29392913
}
29402914

2941-
if (enableProfilerTimer && enableProfilerNestedUpdateScheduledHook) {
2942-
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
2943-
// Updates scheduled during ref detachment should also be flagged.
2944-
rootCommittingMutationOrLayoutEffects = root;
2945-
}
2946-
29472915
// The next phase is the mutation phase, where we mutate the host tree.
29482916
commitMutationEffects(root, finishedWork, lanes);
29492917

@@ -2982,10 +2950,6 @@ function commitRootImpl(
29822950
markLayoutEffectsStopped();
29832951
}
29842952

2985-
if (enableProfilerTimer && enableProfilerNestedUpdateScheduledHook) {
2986-
rootCommittingMutationOrLayoutEffects = null;
2987-
}
2988-
29892953
// Tell Scheduler to yield at the end of the frame, so the browser has an
29902954
// opportunity to paint.
29912955
requestPaint();

0 commit comments

Comments
 (0)