Skip to content

Commit 79aece3

Browse files
gaearonEthan-Arrowood
authored andcommitted
Don't reset error codes on CI build (facebook#11655)
* Don't reset error codes on CI build * Add an explanation
1 parent fea916d commit 79aece3

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

scripts/circleci/build.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ set -e
44

55
yarn build --extract-errors
66

7+
# Note: since we run the full build including extracting error codes,
8+
# it is important that we *don't* reset the change to `scripts/error-codes/codes.json`.
9+
# When production bundle tests run later, it needs to be available.
10+
# See https://github.com/facebook/react/pull/11655.
11+
712
# Do a sanity check on bundles
813
node ./scripts/rollup/validate/index
914

0 commit comments

Comments
 (0)