Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

library should be named FirebaseArduino #108

Closed
proppy opened this issue Apr 27, 2016 · 8 comments
Closed

library should be named FirebaseArduino #108

proppy opened this issue Apr 27, 2016 · 8 comments

Comments

@proppy
Copy link
Contributor

proppy commented Apr 27, 2016

To match other Arduino library name style.

@proppy proppy closed this as completed Apr 27, 2016
@proppy proppy reopened this Apr 27, 2016
@proppy proppy changed the title remove should be named FirebaseArduino repo should be named FirebaseArduino Apr 27, 2016
@ed7coyne
Copy link
Collaborator

We don't need to rename the repo if we implement #73 .

This would meld well with #92 as well as we can keep them in the same repo but have separate libraries.

Development becomes a little harder then as you can't just "git clone" into your arduino/libraries you will need to add symlinks but developers are in the minority of users and I don't think that is too bad.

@ed7coyne
Copy link
Collaborator

ed7coyne commented May 6, 2016

I am wrong in my previous post. You can only create a library from a release (or tag) on the whole repo so we can't have two libraries in sub-dirs of the repo and list them both in arduino.

@proppy
Copy link
Contributor Author

proppy commented May 8, 2016

@ed7coyne can't we just point to actual tarball?

@ed7coyne
Copy link
Collaborator

ed7coyne commented May 9, 2016

@proppy You mean to release as an Arduino library?

If so then no we can't according to https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-add-my-library-to-library-manager they want you to point them to an github repo and they will scrape releases from it, they don't seem to allow you to push random tarballs.

@proppy
Copy link
Contributor Author

proppy commented May 9, 2016

GitHub used to allow to attach arbitrary tarball in a releases, but I wonder if their tool would download it as it.

@ed7coyne
Copy link
Collaborator

ed7coyne commented May 9, 2016

Oh, interesting all I can find now is what it shows on the "releases" tab and it talks about creating them from tags, which are representations of the entire repo from what I understand.

@proppy
Copy link
Contributor Author

proppy commented May 10, 2016

Yes, but you can also attach binary, see the bottom of this UI:
https://github.com/googlesamples/firebase-arduino/releases/new

I wonder if the arduino package manager can target those.

@ed7coyne
Copy link
Collaborator

Hmm interesting. So if you do that it publishes both the source code at that tag and the binary you attached, example here where I attached test.tar.gz: https://github.com/ed7coyne/firebase-arduino/releases

However if you inspect "dist/library_index.json" under your arduino install dir you can see all of the library urls. There are 864 listed and they all correspond to the https://github.com/user/project/archive/version.zip format which is the autogenerated packages and not the ../user/project/releases/download/* format which is the attached binaries.

Unfortunately they don't definitively say anywhere but I think that is fairly conclusive that they will only accept the github generated packages. I can see a lot of logic to this as well, that way you know that what you are running is what is in the source on github and it would be a little harder for someone to add malicious code.

@ed7coyne ed7coyne changed the title repo should be named FirebaseArduino library should be named FirebaseArduino May 14, 2016
@proppy proppy closed this as completed May 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants