-
Notifications
You must be signed in to change notification settings - Fork 491
library should be named FirebaseArduino #108
Comments
We don't need to rename the repo if we implement #73 . This would meld well with #92 as well as we can keep them in the same repo but have separate libraries. Development becomes a little harder then as you can't just "git clone" into your arduino/libraries you will need to add symlinks but developers are in the minority of users and I don't think that is too bad. |
I am wrong in my previous post. You can only create a library from a release (or tag) on the whole repo so we can't have two libraries in sub-dirs of the repo and list them both in arduino. |
@ed7coyne can't we just point to actual tarball? |
@proppy You mean to release as an Arduino library? If so then no we can't according to https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-add-my-library-to-library-manager they want you to point them to an github repo and they will scrape releases from it, they don't seem to allow you to push random tarballs. |
GitHub used to allow to attach arbitrary tarball in a releases, but I wonder if their tool would download it as it. |
Oh, interesting all I can find now is what it shows on the "releases" tab and it talks about creating them from tags, which are representations of the entire repo from what I understand. |
Yes, but you can also attach binary, see the bottom of this UI: I wonder if the arduino package manager can target those. |
Hmm interesting. So if you do that it publishes both the source code at that tag and the binary you attached, example here where I attached test.tar.gz: https://github.com/ed7coyne/firebase-arduino/releases However if you inspect "dist/library_index.json" under your arduino install dir you can see all of the library urls. There are 864 listed and they all correspond to the https://github.com/user/project/archive/version.zip format which is the autogenerated packages and not the ../user/project/releases/download/* format which is the attached binaries. Unfortunately they don't definitively say anywhere but I think that is fairly conclusive that they will only accept the github generated packages. I can see a lot of logic to this as well, that way you know that what you are running is what is in the source on github and it would be a little harder for someone to add malicious code. |
To match other Arduino library name style.
The text was updated successfully, but these errors were encountered: