Skip to content

Commit c58abc0

Browse files
author
Harry Terkelsen
authored
[firebase_core] Check kIsWeb in firebase_core (#1487)
* Add kIsWeb check to defaultAppName * Bump version of firebase_core * Bump to 0.4.2+1 instead of 0.4.3
1 parent 5840548 commit c58abc0

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

packages/firebase_core/firebase_core/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.4.2+1
2+
3+
* Check `kIsWeb` before checking `Platform.isIos` for the default app name.
4+
15
## 0.4.2
26

37
* Migrate to `firebase_core_platform_interface`.

packages/firebase_core/firebase_core/lib/firebase_core.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'dart:async';
88
import 'dart:io' show Platform;
99

1010
import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart';
11+
import 'package:flutter/foundation.dart' show kIsWeb;
1112
import 'package:meta/meta.dart';
1213

1314
export 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart'

packages/firebase_core/firebase_core/lib/src/firebase_app.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class FirebaseApp {
1212
final String name;
1313

1414
static final String defaultAppName =
15-
Platform.isIOS ? '__FIRAPP_DEFAULT' : '[DEFAULT]';
15+
(!kIsWeb && Platform.isIOS) ? '__FIRAPP_DEFAULT' : '[DEFAULT]';
1616

1717
/// A copy of the options for this app. These are non-modifiable.
1818
///

packages/firebase_core/firebase_core/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Core, enabling connecting to multiple
33
Firebase apps.
44
author: Flutter Team <[email protected]>
55
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_core/firebase_core
6-
version: 0.4.2
6+
version: 0.4.2+1
77

88
flutter:
99
plugin:

0 commit comments

Comments
 (0)